-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPR]: MATLAB-specific handling in edx-platform #192
Comments
There was a slack thread about this as well. |
Just to be clear @ormsbee , would this DEPR also cover the Matlab API Key field in the problem editor, thus clearing up 2U's T&L team to remove it from the new React-based problem editor? (cc @jristau1984) |
@kdmccormick: Yes, but to be clear: I don't think that work needs to wait for this DEPR to be accepted, since it's more of a bookkeeping DEPR–i.e. I'm pretty sure that it's been broken for years, so immediately removing the view of the broken thing doesn't negatively impact users. I'm leaving it open for a couple of weeks of comment Just In Case, and if people want to add any more information. |
This DEPR was announced here: https://discuss.openedx.org/t/deprecation-removal-matlab-specific-handling-in-edx-platform/10069/5 |
MATLAB support was baked into the ProblemBlock with its own input type. The MathWorks-provided backend that this input type interacts with is no longer supported, and course teams have long-since moved on to the recommended LTI interface instead. This removes all MATLAB-specific code in edx-platform. See DEPR openedx#192 for more details: openedx/public-engineering#192
The Matlab-specific code is coupled with XQueue in places, making its removal a little tricky. But we at least want to hide this now-useless field from end-users before we cut the Quince release. openedx/public-engineering#192
The Matlab-specific code is coupled with XQueue in places, making its removal a little tricky. But we at least want to hide this now-useless field from end-users before we cut the Quince release. openedx/public-engineering#192
@ormsbee is this DEPR complete now? |
@dianakhuang: No, its not. I removed it from the settings interface so that people wouldn't see it anymore, but I didn't remove the underlying code because a lot of capa's xqueue interface code uses MATLAB for its tests. So if I removed MATLAB, I'd have to re-implement those tests for xqueue, which didn't seem worthwhile since xqueue itself was on the chopping block. I'm now thinking that this DEPR will be executed when the xqueue code in edx-platform finally dies as part of #286 |
Overview
Our system currently has special handling for MATLAB problems via an old integration through xqueue that isn't really supported any longer, and appears to be broken today. Since this integration should now be done via LTI, we can remove:
matlab_api_key
attribute in ProblemBlock, as well as the version defined for inheritance purposes.MatlabInput
coderesponse
and xqueue.This would eliminate the "MATLAB API Key" advanced course setting UI in Studio:
And the equivalent one at the ProblemBlock level:
Effect on old course content:
Proposal Date
10 May 2023
Target Ticket Acceptance Date
24 May 2023
Earliest Open edX Named Release Without This Functionality
Quince.
Since it is not currently in a working state, there's no need to offer an extra release for migration.
Rationale
The text was updated successfully, but these errors were encountered: