feat!: stop syncing labels from labels.yaml #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repo_checks[1] tool now does this, and we don't want two systems simultaneously trying to create or delete labels. Note that the bot will still *add* and *delete* a handful of labels from *PRs* (`open-source-pull-request`, `blended`, etc). What this commit changes is that the bot will not longer *create* nor *delete* labels from the *entire repository*. The `labels.yaml` file is now unused and can be safely deleted from any openedx-webhooks data repositories. [1] https://github.com/openedx/repo-tools/tree/master/edx_repo_tools/repo_checks Part of: #218
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 90.30% 89.73% -0.58%
==========================================
Files 74 73 -1
Lines 4558 4343 -215
Branches 469 456 -13
==========================================
- Hits 4116 3897 -219
- Misses 405 410 +5
+ Partials 37 36 -1
☔ View full report in Codecov by Sentry. |
feanil
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the work from #245, but also removes the now-obsolete test helper code.