Skip to content

Commit 42da734

Browse files
authored
feat!: upgraded to node v18, added .nvmrc and updated workflows (#452)
BREAKING CHANGE: upgrade node JS to support to v18 * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages
1 parent 5380b1f commit 42da734

File tree

6 files changed

+1023
-16633
lines changed

6 files changed

+1023
-16633
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,17 @@ on:
1111
jobs:
1212
tests:
1313
runs-on: ubuntu-20.04
14-
strategy:
15-
matrix:
16-
node: [16]
17-
npm: [8.5.x]
1814
steps:
1915
- name: Checkout
2016
uses: actions/checkout@v3
2117

18+
- name: Setup Nodejs Env
19+
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
20+
2221
- name: Setup Nodejs
2322
uses: actions/setup-node@v3
2423
with:
25-
node-version: "${{ matrix.node }}"
26-
27-
# This is a temporary "hack" to unblock CI/releases, as ideally we should avoid needing to pin NPM to a specific minor version. By doing
28-
# so, we are basically deferring clean up of peer dependencies to a later time. See https://github.com/npm/cli/issues/4664 for more details.
29-
- name: Pin NPM version
30-
run: npm install -g npm@${{ matrix.npm }}
24+
node-version: ${{ env.NODE_VER }}
3125

3226
- name: Install dependencies
3327
run: npm ci

.github/workflows/lockfileversion-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ on:
1010

1111
jobs:
1212
version-check:
13-
uses: openedx/.github/.github/workflows/lockfileversion-check.yml@master
13+
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,13 @@ jobs:
1414
with:
1515
fetch-depth: 0
1616

17+
- name: Setup Nodejs Env
18+
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
19+
1720
- name: Setup Node.js
1821
uses: actions/setup-node@v3
1922
with:
20-
node-version: 18
23+
node-version: ${{ env.NODE_VER }}
2124

2225
- name: Install dependencies
2326
run: npm ci

.nvmrc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
v16
2-
1+
18

0 commit comments

Comments
 (0)