Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of query-string dependency for URLSearchParams #571

Open
jsnwesson opened this issue Feb 21, 2025 · 0 comments
Open

Replace use of query-string dependency for URLSearchParams #571

jsnwesson opened this issue Feb 21, 2025 · 0 comments
Labels
good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@jsnwesson
Copy link
Contributor

Upgrading to query-string v8+ has been a pain point for codebases, and Learner Dashboard is no exception.

What I've discovered is that our use for query-string in Learner Dashboard can be fulfilled with URLSearchParams, which occurs in two files (hook.js and src/data/services/lms/utils.js), and so instead of trying to fix the failed tests for upgrading query-string to v9, I suggest replacing it completely.

This will require updating the tests for both files and removing the query-string dependency from package.json.

@jsnwesson jsnwesson added good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
Status: No status
Development

No branches or pull requests

1 participant