Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course: Libraries Page: Review Content Updates Tab #1566

Open
Tracked by #1097
bradenmacdonald opened this issue Dec 10, 2024 · 2 comments
Open
Tracked by #1097

Course: Libraries Page: Review Content Updates Tab #1566

bradenmacdonald opened this issue Dec 10, 2024 · 2 comments
Labels
enhancement Relates to new features or improvements to existing features

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Dec 10, 2024

Designs are being revised but the initial version is here in Figma: https://www.figma.com/design/Y3gSyrpG6uncUUfjK7eQuo/Content-Libraries-v2.1-%5BOpen-edX%5D?node-id=1549-46616&t=hhz5Rljy8gvcwIUY-4

Screenshot

@edschema
Copy link

Here are updated designs for the sync page, @navinkarkera. Thank you for being patient with us! Here are the requested changes:

  • remove preview from the review updates page cards
  • remove 'open in new page' icon
  • reposition 'review updates' button, add sync icon
  • Put 'review updates' button and ignore/accept inline.
  • Remove Help panel for this iteration

A question: for the "review content updates" tab, you have the number of updates in a red circle. I don't recall seeing that design pattern elsewhere. If it isn't elsewhere, I would suggest putting the count in parenthesis as in the screen below.

cc: @sdaitzman @jmakowski1123 @marcotuts

Image

@navinkarkera
Copy link
Contributor

A question: for the "review content updates" tab, you have the number of updates in a red circle. I don't recall seeing that design pattern elsewhere. If it isn't elsewhere, I would suggest putting the count in parenthesis as in the screen below.

@edschema Paragon tabs component supports showing notification count, so I used it just as an experiment. We can revert back to parenthesis if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Relates to new features or improvements to existing features
Projects
Status: UX/UI To Dos
Development

No branches or pull requests

3 participants