Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-10021: Added 3 new columns in module activity report. #1434

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

saleem-latif
Copy link
Contributor

@saleem-latif saleem-latif commented Feb 25, 2025

Jira Ticket: ENT-10021

This PR adds 3 new columns for module activity report's data table and the CSV file that user can download. The columns are listed below

  1. Learning Outcomes: Before This column that contains user's learning outcome score before starting the course.
  2. Learning Outcomes: After This column that contains user's learning outcome score after completing the course.
  3. Learning Outcomes % Difference This columns shows the % increment/decrement in user's learning outcome score.

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@saleem-latif saleem-latif force-pushed the saleem-latif/ENT-10021 branch from 020e22c to e411962 Compare February 25, 2025 12:46
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.42%. Comparing base (da16b85) to head (e411962).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files         660      660           
  Lines       14932    14932           
  Branches     3108     3171   +63     
=======================================
  Hits        12905    12905           
+ Misses       1963     1957    -6     
- Partials       64       70    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only suggestion I have is, as @muhammad-ammar mentioned in ModuleActivityReport.test.jsx, we should also verify that the relevant values exist for the corresponding columns.

@saleem-latif saleem-latif merged commit ffcf685 into master Feb 26, 2025
6 checks passed
@saleem-latif saleem-latif deleted the saleem-latif/ENT-10021 branch February 26, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants