Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: docs: Add TypeScript typings to LmsApiService group methods #1432

Closed
wants to merge 1 commit into from

Conversation

marlonkeating
Copy link
Contributor

This change reverts #1426 pending investigation of why group creation is failing with that change.

Testing Instructions

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.48%. Comparing base (d5fef09) to head (3b0ca28).

Files with missing lines Patch % Lines
src/data/services/LmsApiService.js 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
+ Coverage   86.43%   86.48%   +0.05%     
==========================================
  Files         660      660              
  Lines       14931    14936       +5     
  Branches     3171     3164       -7     
==========================================
+ Hits        12905    12917      +12     
+ Misses       1956     1952       -4     
+ Partials       70       67       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marlonkeating
Copy link
Contributor Author

No longer needed, fix introduced in #1433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant