Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in group creation don't show duplicate error message when members added again #1425

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

marlonkeating
Copy link
Contributor

@marlonkeating marlonkeating commented Feb 13, 2025

Jira Ticket

This change makes it so that when members are repeatedly added to a group from the member table, a duplicate error is not shown.

Testing Instructions

  • Go to the admin-portal repo, pull down branch, and run npm run start:stage
  • Navigate to https://localhost.stage.edx.org:1991/alc-general/admin/people-management
  • Click 'Create group'
  • Check one member and click 'Add' button
  • While leaving first member checked, check another member in the table, click 'Add' again
  • Verify that both members are shown in the Summary section, and there is no error message indicating duplicate members have been added.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (c3e9edf) to head (26b4323).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1425   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         660      660           
  Lines       14921    14921           
  Branches     3159     3163    +4     
=======================================
  Hits        12902    12902           
  Misses       1949     1949           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marlonkeating marlonkeating merged commit 32858b5 into master Feb 14, 2025
6 checks passed
@marlonkeating marlonkeating deleted the mkeating/ENT-10046 branch February 14, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants