Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove usage of useCache and ADR #1424

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Conversation

brobro10000
Copy link
Member

Remove usage of useCache option from frontend-platform's, getAuthenticatedHttpClient method.
This change resolves the issue of inadvertently modifying the expected headers our services expect during the request/response lifecycle.

Includes an ADR to document the change and reasoning for its removal, along with providing potential solutions to client side caching.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.46%. Comparing base (c0a427f) to head (c640dc8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/data/services/EcommerceApiService.js 0.00% 1 Missing ⚠️
src/data/services/EnterpriseCatalogApiService.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1424   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         660      660           
  Lines       14921    14921           
  Branches     3167     3105   -62     
=======================================
  Hits        12902    12902           
- Misses       1949     1952    +3     
+ Partials       70       67    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 6d19d00 into master Feb 12, 2025
5 of 6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-useCache-depr branch February 12, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants