fix: createEnterpriseGroup response camelCase (#1433)

test: fix createEnterpriseGroup returns uuid for the post request
openedx · Feb 20, 2025 · 97f1445 · 97f1445
1 parent d5fef09
commit 97f1445
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/src/data/services/LmsApiService.ts b/src/data/services/LmsApiService.ts
@@ -66,14 +66,20 @@ class LmsApiService {
 
   static enterpriseLearnerUrl = `${LmsApiService.baseUrl}/enterprise/api/v1/enterprise-learner/`;
 
-  static createEnterpriseGroup({ groupName, enterpriseUUID }: CreateEnterpriseGroupArgs): EnterpriseGroup {
+  static async createEnterpriseGroup(
+    {
+      groupName,
+      enterpriseUUID,
+    }: CreateEnterpriseGroupArgs,
+  ): EnterpriseGroupResponse {
     const postParams = {
       name: groupName,
       enterprise_customer: enterpriseUUID,
       members: [],
     };
     const createEnterpriseGroupUrl = `${LmsApiService.enterpriseGroupListUrl}`;
-    return camelCaseObject(LmsApiService.apiClient().post(createEnterpriseGroupUrl, postParams));
+    const response = await LmsApiService.apiClient().post(createEnterpriseGroupUrl, postParams);
+    return camelCaseObject(response);
   }
 
   static fetchEnterpriseSsoOrchestrationRecord(configurationUuid) {

diff --git a/src/data/services/tests/LmsApiService.test.js b/src/data/services/tests/LmsApiService.test.js
@@ -100,10 +100,10 @@ describe('LmsApiService', () => {
       },
     });
     const response = await LmsApiService.createEnterpriseGroup({
-      name: 'test-name',
-      enterprise_customer: 'test-customer-uuid',
-      members: [],
+      groupName: 'test-name',
+      enterpriseUUID: 'test-customer-uuid',
     });
+
     expect(response).toEqual({
       status: 201,
       data: {
@@ -113,6 +113,14 @@ describe('LmsApiService', () => {
         members: [],
       },
     });
+    expect(axios.post).toHaveBeenCalledWith(
+      `${lmsBaseUrl}/enterprise/api/v1/enterprise_group/`,
+      {
+        name: 'test-name',
+        enterprise_customer: 'test-customer-uuid',
+        members: [],
+      },
+    );
   });
   test('fetchReportingConfigs returns reporting configs', async () => {
     axios.get.mockResolvedValue({