Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-0057: initiate openedx forum django app #7

Merged
merged 3 commits into from
Jul 26, 2024
Merged

FC-0057: initiate openedx forum django app #7

merged 3 commits into from
Jul 26, 2024

Conversation

Faraz32123
Copy link
Contributor

@Faraz32123 Faraz32123 commented Jul 25, 2024 •
edited
Loading

feat: initiate openedx forum django app
1c7e58c 
initiated openedx forum django app using edx-cookiecutters
https://github.com/openedx/edx-cookiecutters
@Faraz32123 Faraz32123 requested a review from regisb July 25, 2024 10:08
@Faraz32123 Faraz32123 changed the title feat: initiate openedx forum django app FC-0057: initiate openedx forum django app Jul 25, 2024
@Faraz32123 Faraz32123 force-pushed the feat/initiate_openedx_forum_django_app branch from d948ea9 to 8ea0c30 Compare July 26, 2024 05:49
fix: add and upgrade requirement files
07fe4e2 
github workflows were failing due to
- ci.txt and dev.txt did not exist
- tox command does not exits
@Faraz32123 Faraz32123 force-pushed the feat/initiate_openedx_forum_django_app branch from 8ea0c30 to 07fe4e2 Compare July 26, 2024 06:05
@regisb regisb requested a review from taimoor-ahmed-1 July 26, 2024 08:03
@Faraz32123 Faraz32123 force-pushed the feat/initiate_openedx_forum_django_app branch from e80a20c to 56ad0af Compare July 26, 2024 09:29
fix: update ci workflows
dc0ae67 
- use codecov actions without CODECOV_TOKEN as its a public repository
- set fail_ci_if_error flag to False
- format forum/__init__.py
@Faraz32123 Faraz32123 force-pushed the feat/initiate_openedx_forum_django_app branch from 56ad0af to dc0ae67 Compare July 26, 2024 09:45
regisb
regisb approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a whole lot of code to change or remove, but otherwise this LGTM :)

@Faraz32123 Faraz32123 merged commit b0a5907 into master Jul 26, 2024
6 checks passed
@Faraz32123 Faraz32123 deleted the feat/initiate_openedx_forum_django_app branch July 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisb regisb regisb approved these changes

@taimoor-ahmed-1 taimoor-ahmed-1 Awaiting requested review from taimoor-ahmed-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup the forum app using the edx-cookiecutter
2 participants
@Faraz32123 @regisb