Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ubuntu image to latest in forum workflows #162

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

taimoor-ahmed-1
Copy link
Contributor

@taimoor-ahmed-1 taimoor-ahmed-1 commented Feb 13, 2025

This PR includes the following updates:

Ubuntu Version: Updated the Ubuntu version in the PyPI publish workflow to the latest stable release to ensure compatibility with the latest packages and dependencies.
ReadTheDocs Configuration: Edited the .readthedocs.yaml file to align with recent project requirements or to fix any issues with documentation builds.

@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Feb 13, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently unmaintained.

🔘 Find a technical reviewer To get help with finding a technical reviewer, reach out to the community contributions project manager for this PR:
  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your project manager.
  2. Find their GitHub handle here.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 13, 2025
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the chore/update_ubuntu_to_latest_version_for_pypi branch from 08def61 to 42a8a07 Compare February 13, 2025 08:16
@taimoor-ahmed-1 taimoor-ahmed-1 changed the title chore: update ubuntu image to latest in pypi chore: update ubuntu image to latest in forum workflows Feb 13, 2025
Copy link
Contributor

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@regisb
Copy link
Contributor

regisb commented Feb 13, 2025

This repository is currently unmaintained.

This message from @openedx-webhooks is incorrect. What do we have to do to fix that?

EDIT: it's probably related to #161

@@ -12,7 +12,7 @@ sphinx:

# Set the version of python needed to build these docs.
build:
os: "ubuntu-22.04"
os: "ubuntu-latest"
tools:
python: "3.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR but it's probably worth updating this to one of the newer python versions.

@feanil feanil merged commit 6365c49 into master Feb 20, 2025
10 checks passed
@feanil feanil deleted the chore/update_ubuntu_to_latest_version_for_pypi branch February 20, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants