-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: delete thread throwing error #159
Conversation
Thanks for the pull request, @taimoor-ahmed-1! This repository is currently unmaintained.
To get help with finding a technical reviewer, reach out to the community contributions project manager for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM!
Did we identified the edge case why thread_id
is not present in User's read_states although it should exists?
Yes, each read state has course_id field and contains thread_ids for only that course. The issue with current code was that it was trying to delete thread_id from all read_states of the user which is not possible because a thread_id can exist in only one course/read_state. |
LGTM! |
This PR fixes delete thread api throwing an error when the thread id wasn't being fetched from the users' read states.
Each read state has course_id field and contains thread_ids for only that course. The issue with current code was that it was trying to delete thread_id from all read_states of the user which is not possible because a thread_id can exist in only one course/read_state of a user.
close #147