Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add group_id and group_ids params in the get_user_threads #146

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Ali-Salman29
Copy link
Contributor

The PR contains a fix for the issue mentioned in the PR #142

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 15, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @Ali-Salman29!

This repository is currently unmaintained.

🔘 Find a technical reviewer

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Ali-Salman29 Ali-Salman29 force-pushed the alisalman/fix-thread-api-cohort-users branch from 1c12dc0 to 8006044 Compare January 15, 2025 12:28
Copy link
Contributor

@taimoor-ahmed-1 taimoor-ahmed-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ali-Salman29 Ali-Salman29 force-pushed the alisalman/fix-thread-api-cohort-users branch from 5cd69e7 to 8a9f08d Compare January 16, 2025 09:55
@Ali-Salman29 Ali-Salman29 force-pushed the alisalman/fix-thread-api-cohort-users branch from 8a9f08d to 956b33d Compare January 16, 2025 10:15
@Ali-Salman29 Ali-Salman29 requested a review from regisb January 16, 2025 10:15
@Ali-Salman29 Ali-Salman29 force-pushed the alisalman/fix-thread-api-cohort-users branch from 77ede8c to 4f59d32 Compare January 16, 2025 11:34
The PR contains a fix for the issue mentioned in the PR #142

close #142
@Ali-Salman29 Ali-Salman29 force-pushed the alisalman/fix-thread-api-cohort-users branch from 4f59d32 to a6ec30b Compare January 16, 2025 11:42
@Ali-Salman29 Ali-Salman29 merged commit 342ad3b into master Jan 16, 2025
10 checks passed
@Ali-Salman29 Ali-Salman29 deleted the alisalman/fix-thread-api-cohort-users branch January 16, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants