Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination not working for Comments API #151

Closed
muhammadadeeltajamul opened this issue Jan 24, 2025 · 4 comments · Fixed by #154
Closed

Pagination not working for Comments API #151

muhammadadeeltajamul opened this issue Jan 24, 2025 · 4 comments · Fixed by #154
Assignees
Labels
bug Report of or fix for something that isn't working as intended release blocker Blocks the upcoming release (fix needed)

Comments

@muhammadadeeltajamul
Copy link

Pagination is not working for comments API with Forum. Pagination work with same parameters when using cs_comments_service

Url I tested on : api/discussion/v1/comments/?thread_id={thread_id}&page_size=10&page=1&reverse_order=true&requested_fields=profile_image&enable_in_context_sidebar=false

@muhammadadeeltajamul muhammadadeeltajamul added bug Report of or fix for something that isn't working as intended release blocker Blocks the upcoming release (fix needed) labels Jan 24, 2025
@Ali-Salman29
Copy link
Contributor

Thank You, I reproduced this issue. I'll get back to you soon.

@Ali-Salman29 Ali-Salman29 self-assigned this Jan 24, 2025
Ali-Salman29 added a commit that referenced this issue Jan 27, 2025
Ali-Salman29 added a commit that referenced this issue Jan 27, 2025
- Add pagination in thread comments

close #151
Ali-Salman29 added a commit that referenced this issue Jan 27, 2025
- Add pagination in thread comments

close #151
@ormsbee
Copy link

ormsbee commented Jan 29, 2025

@muhammadadeeltajamul: In general, when you're filing these bugs, can you please specify whether you're running the forums against MongoDB or MySQL?

@Ali-Salman29
Copy link
Contributor

@ormsbee I've fixed the pagination issue in this PR. I've to add some tests only.

@muhammadadeeltajamul
Copy link
Author

@ormsbee I will keep that in my mind when creating issues. All the issues I have opened till now, they are all on MongoDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended release blocker Blocks the upcoming release (fix needed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants