-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion XBlocks are not working #149
Comments
Can you share the stracktrace from the backend? Also, what do you mean by "Enable Forum V2 for a course that is using old discussion provider"? |
I am not sure if stack-trace will be helpful since there may be more than one errors. Reproducing it and debugging it locally will be a better approach. edX support two native discussion provider (rest of discussion providers are third-party providers). Old discussion provider uses discussion xblocks (Default for openedx) whereas new discussion provider uses discussion sidebar (Default for 2U). You can use app-learning MFE to view discussion xblocks
|
Thank You for providing the details. I'll look into this and get back to you as soon as possible. |
https://github.com/openedx-unsupported/xblock-discussion |
This is the setup I am using
|
The xblock is not compatible with the newer version. Can you please mention the openedX version that is compatible with this xblock? |
Could you please confirm which version of the devstack (openedX release) you are using? |
@Ali-Salman29 |
When you've figured out the right set of waffle flags to toggle to get old discussion blocks to display, could you please record them in this ticket? Thank you. |
Hi, @ormsbee no flags are required for using xblock in the new installation please use this fork for devstack |
Can someone please explain why the forum v2 API is not compatible with this "old" discussion xblock? (whatever it is) Which part of the forum v2 API is not backward-compatible? Is it because of one of the limitations listed in this document? |
Hi, @regisb have you tested xblock with forum v2 with mondgo? and limitations listed in the provided document do not include anything about old discussions view and xblock , our assumption is forum v2 is drop-in replacement for cs_comment_service and all of the stuff that was working with cs_commet service should work with forum v2. Our initial testing on local devstack indicates that thread APIs in forum v2 are not 1:1 replacements for APIs in cs_comment service, Some params that are being used by xblock are not implemented in forum v2 . If you need any help in reproducing this issue please let me know. |
Here is stack trace for this issue
|
This is very helpful information, thank you Ahtisham. This stacktrace highlights the fact that the problem does not lie with an API incompatibility. Instead, it seems that it's just a matter of calling the API with too many arguments. This used to be OK with the HTTP API, because unnecessary arguments were just being silently swallowed. But with this native Python API, unused arguments trigger a TypeError. There might be further issues down the road, but I'm confident that this specific one can be resolved quite easily. |
The get_user_threads api was not accepting additional arguments and there the discussion xblock wasn't working with the forum service. This PR adds args and kwargs params to the api to avoid breakage. close #149
The get_user_threads api was not accepting additional arguments and there the discussion xblock wasn't working with the forum service. This PR adds args and kwargs params to the api to avoid breakage. close #149
The get_user_threads api was not accepting additional arguments and there the discussion xblock wasn't working with the forum service. This PR adds args and kwargs params to the api to avoid breakage. close #149
@AhtishamShahid can you please try out the following fix? #160 |
|
Steps to render discussions xblock and reproduce this error.
|
Discussion xblocks are breaking when Forum V2 is enabled. This issue could impact Open edX community as default provider for them uses discussion xblocks, and they fail to load when the Forum v2 is active. This is also breaking old UI of discussions experience.
How to reproduce:
The text was updated successfully, but these errors were encountered: