fix: requirements to make forum work with edx-platform (#121)

* fix: pin pylint to the same version as that of edx As updating the pylint version to latest fails edx CI and If pinning it to the same version as it(forum) has before, it fails compiling the requirements in edx-platofrm So, adding the same constraint for pylint as edx-platform has for it. i.e. `pylint<2.16.0` * fix: upgrade requirements - added `too-many-positional-arguments` disable list in pylintrc to fix these warning:https://github.com/edly-io/forum/actions/runs/11513603527/job/32050616644 --------- Co-authored-by: Muhammad Faraz Maqsood <[email protected]> Co-authored-by: Muhammad Faraz Maqsood <[email protected]>
openedx · Oct 25, 2024 · 38183d2 · 38183d2
1 parent 6f794b8
commit 38183d2
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 80 deletions.
diff --git a/pylintrc b/pylintrc
@@ -293,6 +293,7 @@ disable =
 	bad-option-value,
 	missing-timeout,
 	useless-suppression,
+	too-many-positional-arguments,
 
 [REPORTS]
 output-format = text

diff --git a/requirements/base.in b/requirements/base.in
@@ -10,4 +10,3 @@ requests
 pymongo
 elasticsearch
 mysqlclient
-pylint==3.2.7
diff --git a/requirements/base.txt b/requirements/base.txt
@@ -6,16 +6,12 @@
 #
 asgiref==3.8.1
     # via django
-astroid==3.2.4
-    # via pylint
 certifi==2024.8.30
     # via
     #   elasticsearch
     #   requests
 charset-normalizer==3.4.0
     # via requests
-dill==0.3.9
-    # via pylint
 django==4.2.16
     # via
     #   -c https://raw.githubusercontent.com/edx/edx-lint/master/edx_lint/files/common_constraints.txt
@@ -31,26 +27,16 @@ elasticsearch==7.13.4
     #   -r requirements/base.in
 idna==3.10
     # via requests
-isort==5.13.2
-    # via pylint
-mccabe==0.7.0
-    # via pylint
 mysqlclient==2.2.5
     # via -r requirements/base.in
 openedx-atlas==0.6.2
     # via -r requirements/base.in
-platformdirs==4.3.6
-    # via pylint
-pylint==3.2.7
-    # via -r requirements/base.in
 pymongo==4.10.1
     # via -r requirements/base.in
 requests==2.32.3
     # via -r requirements/base.in
 sqlparse==0.5.1
     # via django
-tomlkit==0.13.2
-    # via pylint
 urllib3==1.26.20
     # via
     #   elasticsearch

diff --git a/requirements/ci.txt b/requirements/ci.txt
@@ -9,7 +9,7 @@ asgiref==3.8.1
     #   -r requirements/quality.txt
     #   django
     #   django-stubs
-astroid==3.2.4
+astroid==3.3.5
     # via
     #   -r requirements/quality.txt
     #   pylint
@@ -167,7 +167,7 @@ pycodestyle==2.12.1
     # via -r requirements/quality.txt
 pydocstyle==6.3.0
     # via -r requirements/quality.txt
-pylint==3.2.7
+pylint==3.3.1
     # via
     #   -r requirements/quality.txt
     #   edx-lint

diff --git a/requirements/dev.txt b/requirements/dev.txt
@@ -10,7 +10,7 @@ asgiref==3.8.1
     #   -r requirements/quality.txt
     #   django
     #   django-stubs
-astroid==3.2.4
+astroid==3.3.5
     # via
     #   -r requirements/ci.txt
     #   -r requirements/quality.txt
@@ -249,7 +249,7 @@ pydocstyle==6.3.0
     #   -r requirements/quality.txt
 pygments==2.18.0
     # via diff-cover
-pylint==3.2.7
+pylint==3.3.1
     # via
     #   -r requirements/ci.txt
     #   -r requirements/quality.txt

diff --git a/requirements/doc.txt b/requirements/doc.txt
@@ -12,10 +12,6 @@ asgiref==3.8.1
     # via
     #   -r requirements/test.txt
     #   django
-astroid==3.2.4
-    # via
-    #   -r requirements/test.txt
-    #   pylint
 babel==2.16.0
     # via
     #   pydata-sphinx-theme
@@ -57,10 +53,6 @@ coverage[toml]==7.6.4
     # via
     #   -r requirements/test.txt
     #   pytest-cov
-dill==0.3.9
-    # via
-    #   -r requirements/test.txt
-    #   pylint
 distlib==0.3.9
     # via
     #   -r requirements/test.txt
@@ -110,10 +102,6 @@ iniconfig==2.0.0
     # via
     #   -r requirements/test.txt
     #   pytest
-isort==5.13.2
-    # via
-    #   -r requirements/test.txt
-    #   pylint
 jaraco-classes==3.4.0
     # via keyring
 jaraco-context==6.0.1
@@ -133,10 +121,6 @@ markupsafe==3.0.2
     # via
     #   -r requirements/test.txt
     #   jinja2
-mccabe==0.7.0
-    # via
-    #   -r requirements/test.txt
-    #   pylint
 mdurl==0.1.2
     # via markdown-it-py
 mongomock==4.2.0.post1
@@ -169,7 +153,6 @@ pkginfo==1.10.0
 platformdirs==4.3.6
     # via
     #   -r requirements/test.txt
-    #   pylint
     #   tox
     #   virtualenv
 pluggy==1.5.0
@@ -187,8 +170,6 @@ pygments==2.18.0
     #   readme-renderer
     #   rich
     #   sphinx
-pylint==3.2.7
-    # via -r requirements/test.txt
 pymongo==4.10.1
     # via -r requirements/test.txt
 pyproject-api==1.8.0
@@ -282,10 +263,6 @@ text-unidecode==1.3
     # via
     #   -r requirements/test.txt
     #   python-slugify
-tomlkit==0.13.2
-    # via
-    #   -r requirements/test.txt
-    #   pylint
 tox==4.23.2
     # via -r requirements/test.txt
 twine==5.1.1

diff --git a/requirements/quality.txt b/requirements/quality.txt
@@ -9,9 +9,8 @@ asgiref==3.8.1
     #   -r requirements/test.txt
     #   django
     #   django-stubs
-astroid==3.2.4
+astroid==3.3.5
     # via
-    #   -r requirements/test.txt
     #   pylint
     #   pylint-celery
 cachetools==5.5.0
@@ -52,9 +51,7 @@ coverage[toml]==7.6.4
     #   -r requirements/test.txt
     #   pytest-cov
 dill==0.3.9
-    # via
-    #   -r requirements/test.txt
-    #   pylint
+    # via pylint
 distlib==0.3.9
     # via
     #   -r requirements/test.txt
@@ -102,7 +99,6 @@ iniconfig==2.0.0
 isort==5.13.2
     # via
     #   -r requirements/quality.in
-    #   -r requirements/test.txt
     #   pylint
 jinja2==3.1.4
     # via
@@ -113,9 +109,7 @@ markupsafe==3.0.2
     #   -r requirements/test.txt
     #   jinja2
 mccabe==0.7.0
-    # via
-    #   -r requirements/test.txt
-    #   pylint
+    # via pylint
 mongomock==4.2.0.post1
     # via -r requirements/test.txt
 mypy==1.13.0
@@ -152,9 +146,8 @@ pycodestyle==2.12.1
     # via -r requirements/quality.in
 pydocstyle==6.3.0
     # via -r requirements/quality.in
-pylint==3.2.7
+pylint==3.3.1
     # via
-    #   -r requirements/test.txt
     #   edx-lint
     #   pylint-celery
     #   pylint-django
@@ -226,9 +219,7 @@ text-unidecode==1.3
     #   -r requirements/test.txt
     #   python-slugify
 tomlkit==0.13.2
-    # via
-    #   -r requirements/test.txt
-    #   pylint
+    # via pylint
 tox==4.23.2
     # via -r requirements/test.txt
 types-pyyaml==6.0.12.20240917

diff --git a/requirements/test.txt b/requirements/test.txt
@@ -8,10 +8,6 @@ asgiref==3.8.1
     # via
     #   -r requirements/base.txt
     #   django
-astroid==3.2.4
-    # via
-    #   -r requirements/base.txt
-    #   pylint
 cachetools==5.5.0
     # via tox
 certifi==2024.8.30
@@ -33,10 +29,6 @@ colorama==0.4.6
     # via tox
 coverage[toml]==7.6.4
     # via pytest-cov
-dill==0.3.9
-    # via
-    #   -r requirements/base.txt
-    #   pylint
 distlib==0.3.9
     # via virtualenv
     # via
@@ -65,18 +57,10 @@ idna==3.10
     #   requests
 iniconfig==2.0.0
     # via pytest
-isort==5.13.2
-    # via
-    #   -r requirements/base.txt
-    #   pylint
 jinja2==3.1.4
     # via code-annotations
 markupsafe==3.0.2
     # via jinja2
-mccabe==0.7.0
-    # via
-    #   -r requirements/base.txt
-    #   pylint
 mongomock==4.2.0.post1
     # via -r requirements/test.in
 mysqlclient==2.2.5
@@ -93,16 +77,12 @@ pbr==6.1.0
     # via stevedore
 platformdirs==4.3.6
     # via
-    #   -r requirements/base.txt
-    #   pylint
     #   tox
     #   virtualenv
 pluggy==1.5.0
     # via
     #   pytest
     #   tox
-pylint==3.2.7
-    # via -r requirements/base.txt
 pymongo==4.10.1
     # via -r requirements/base.txt
 pyproject-api==1.8.0
@@ -137,10 +117,6 @@ stevedore==5.3.0
     # via code-annotations
 text-unidecode==1.3
     # via python-slugify
-tomlkit==0.13.2
-    # via
-    #   -r requirements/base.txt
-    #   pylint
 tox==4.23.2
     # via -r requirements/test.in
 typing-extensions==4.12.2