-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
33589: Updated mako_block.py to use MakoService #35033
Conversation
Thanks for the pull request, @abdullahQureshee! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @abdullahQureshee! Thank you for this contribution. When you have a moment, would you please put a description of your changes at the top of the pull request? Please also let me know if you have any questions regarding submitting a CLA form. Thank you! |
@abdullahQureshee Should you be listed under the edly/Aribisoft entity CLA? |
Sure. I'm currently doing some RnD on the issue. Once thats done, I'll create a proper PR. Right now its in Draft. I hope its ok to keep the Draft for a bit longer. |
Yes. |
@abdullahQureshee - please have your manager send an email to [email protected] to have you added to the existing CLA. Let me know if you have any questions! |
6f9c694
to
e4d3eb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. @abdullahQureshee can you rebase this of the latest master?
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Resolves #33589. Total of 12005 warnings will be removed according to the deprecated devstack action logs
The
render_template
check has been removed from constructor and there is no check explicitly implemented for existence of the 'mako' service. This should work because a check is already in place at xblock. The runtime class hierarchy is as follows: caching_descriptor_system.py -> x_module.py -> runtime.py