Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send users list in vertical tagging email #4582

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix: send users list in vertical tagging email #4582

merged 1 commit into from
Feb 24, 2025

Conversation

DawoudSheraz
Copy link
Contributor

Followup to #4574 and fixes the email method by sending users instead of user emails.

@Ali-D-Akbar Ali-D-Akbar merged commit e0f63ad into master Feb 24, 2025
14 checks passed
@Ali-D-Akbar Ali-D-Akbar deleted the dsheraz/vertical-tagging-email-fixup branch February 24, 2025 16:51
zawan-ila
zawan-ila reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@zawan-ila zawan-ila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the error, but does it preserve the behavior? The log in the exception will throw too? We probably need a change in the signals file, from where the method is called itself.

@DawoudSheraz DawoudSheraz mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zawan-ila zawan-ila zawan-ila left review comments

@Ali-D-Akbar Ali-D-Akbar Ali-D-Akbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DawoudSheraz @Ali-D-Akbar @zawan-ila