fix: fix marketing url for programs

openedx · Sep 25, 2023 · 145a12e · 145a12e
1 parent 9d997d6
commit 145a12e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/course_discovery/apps/course_metadata/models.py b/course_discovery/apps/course_metadata/models.py
@@ -3304,7 +3304,7 @@ def weeks_to_complete_max(self):
     def marketing_url(self):
         if self.marketing_slug:
             if self.marketing_slug.find('/') != -1:
-                return self.marketing_slug
+                return urljoin(self.partner.marketing_site_url_root, self.marketing_slug)
             path = f'{self.type.slug.lower()}/{self.marketing_slug}'
             return urljoin(self.partner.marketing_site_url_root, path)
 

diff --git a/course_discovery/apps/course_metadata/tests/test_models.py b/course_discovery/apps/course_metadata/tests/test_models.py
@@ -2763,7 +2763,8 @@ def test_marketing_url_without_slug(self):
     def test_marketing_url__with_slashes(self):
         """ Verify the property returns marketing url as it is if marketing_slug contains a slash"""
         self.program.marketing_slug = 'type/subject/org-title'
-        assert self.program.marketing_url == self.program.marketing_slug
+        assert self.program.marketing_url == f"{self.program.partner.marketing_site_url_root}" \
+                                             f"{self.program.marketing_slug}"
 
     def test_course_runs(self):
         """