Skip to content

Commit 57a2823

Browse files
authored
Merge pull request #91 from hbelmiro/RHOAIENG-13327
UPSTREAM: <carry>: Fixed importer component when podToPodTLS is true
2 parents 1f957b5 + a93c860 commit 57a2823

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

backend/src/v2/compiler/argocompiler/importer.go

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package argocompiler
1717
import (
1818
"fmt"
1919
"github.com/kubeflow/pipelines/backend/src/apiserver/common"
20+
"strconv"
2021

2122
wfapi "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
2223
"github.com/kubeflow/pipelines/api/v2alpha1/go/pipelinespec"
@@ -79,6 +80,7 @@ func (c *workflowCompiler) addImporterTemplate() string {
7980
fmt.Sprintf("$(%s)", component.EnvPodUID),
8081
"--mlmd_server_address", common.GetMetadataGrpcServiceServiceHost(),
8182
"--mlmd_server_port", common.GetMetadataGrpcServiceServicePort(),
83+
"--metadataTLSEnabled", strconv.FormatBool(common.GetMetadataTLSEnabled()),
8284
}
8385
importerTemplate := &wfapi.Template{
8486
Name: name,

backend/src/v2/compiler/argocompiler/testdata/importer.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ spec:
4141
- "metadata-grpc-service"
4242
- --mlmd_server_port
4343
- "8080"
44+
- --metadataTLSEnabled
45+
- "false"
4446
command:
4547
- launcher-v2
4648
env:

backend/src/v2/metadata/client.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,9 @@ func NewClient(serverAddress, serverPort string, tlsEnabled bool) (*Client, erro
120120

121121
creds := insecure.NewCredentials()
122122
if tlsEnabled {
123-
config := &tls.Config{}
123+
config := &tls.Config{
124+
InsecureSkipVerify: true, // This should be removed by https://issues.redhat.com/browse/RHOAIENG-13871
125+
}
124126
creds = credentials.NewTLS(config)
125127
}
126128

0 commit comments

Comments
 (0)