cgroups,cmd,generate,validat{e,ion}: fix golangci-lint issues.

klihub · klihub · commit cbbb46652e97 · 2025-11-04T14:22:46.000+02:00
Signed-off-by: Krisztian Litkey &lt;krisztian.litkey@intel.com&gt;
diff --git a/cgroups/cgroups_v1.go b/cgroups/cgroups_v1.go
@@ -539,7 +539,7 @@ func (cg *CgroupV1) GetMemoryData(pid int, cgPath string) (*rspec.LinuxMemory, e
 				return nil, err
 			}
 			kernelLimit := res
-			lm.Kernel = &kernelLimit
+			lm.Kernel = &kernelLimit //nolint:staticcheck
 		case 4:
 			res, err := strconv.ParseInt(strings.TrimSpace(string(contents)), 10, 64)
 			if err != nil {
diff --git a/cmd/runtimetest/main.go b/cmd/runtimetest/main.go
@@ -392,7 +392,7 @@ func (c *complianceTester) validateSysctls(spec *rspec.Spec) error {
 	}
 
 	for k, v := range spec.Linux.Sysctl {
-		keyPath := filepath.Join("/proc/sys", strings.Replace(k, ".", "/", -1))
+		keyPath := filepath.Join("/proc/sys", strings.ReplaceAll(k, ".", "/"))
 		vBytes, err := os.ReadFile(keyPath)
 		if err != nil {
 			return err
@@ -453,10 +453,10 @@ func testFileReadAccess(path string) (readable bool, err error) {
 	}
 	defer f.Close()
 	b := make([]byte, 1)
-	_, err = f.Read(b)
-	if err == nil {
+	switch _, err = f.Read(b); err {
+	case nil:
 		return true, nil
-	} else if err == io.EOF {
+	case io.EOF:
 		// Our validation/ tests only use non-empty files for read-access
 		// tests. So if we get an EOF on the first read, the runtime did
 		// successfully block readability.
@@ -1310,10 +1310,11 @@ func run(context *cli.Context) error {
 	}
 
 	validations := defaultValidations
-	if platform == "linux" {
+	switch platform {
+	case "linux":
 		validations = append(validations, posixValidations...)
 		validations = append(validations, linuxValidations...)
-	} else if platform == "solaris" {
+	case "solaris":
 		validations = append(validations, posixValidations...)
 	}
 
diff --git a/generate/generate.go b/generate/generate.go
@@ -92,7 +92,8 @@ func New(os string) (generator Generator, err error) {
 		}
 	}
 
-	if os == "linux" {
+	switch os {
+	case "linux":
 		config.Process.Capabilities = &rspec.LinuxCapabilities{
 			Bounding: []string{
 				"CAP_CHOWN",
@@ -241,7 +242,7 @@ func New(os string) (generator Generator, err error) {
 			},
 			Seccomp: seccomp.DefaultProfile(&config),
 		}
-	} else if os == "freebsd" {
+	case "freebsd":
 		config.Mounts = []rspec.Mount{
 			{
 				Destination: "/dev",
@@ -597,7 +598,7 @@ func (g *Generator) ClearProcessAdditionalGids() {
 }
 
 // AddProcessAdditionalGid adds an additional gid into g.Config.Process.AdditionalGids.
-func (g *Generator) AddProcessAdditionalGid(gid uint32) {
+func (g *Generator) AddProcessAdditionalGid(gid uint32) { //nolint:staticcheck
 	g.initConfigProcess()
 	for _, group := range g.Config.Process.User.AdditionalGids {
 		if group == gid {
@@ -915,7 +916,7 @@ func (g *Generator) SetLinuxResourcesMemorySwap(swap int64) {
 // SetLinuxResourcesMemoryKernel sets g.Config.Linux.Resources.Memory.Kernel.
 func (g *Generator) SetLinuxResourcesMemoryKernel(kernel int64) {
 	g.initConfigLinuxResourcesMemory()
-	g.Config.Linux.Resources.Memory.Kernel = &kernel
+	g.Config.Linux.Resources.Memory.Kernel = &kernel //nolint:staticcheck
 }
 
 // SetLinuxResourcesMemoryKernelTCP sets g.Config.Linux.Resources.Memory.KernelTCP.
@@ -1066,13 +1067,13 @@ func (g *Generator) ClearPreStartHooks() {
 	if g.Config == nil || g.Config.Hooks == nil {
 		return
 	}
-	g.Config.Hooks.Prestart = []rspec.Hook{}
+	g.Config.Hooks.Prestart = []rspec.Hook{} //nolint:staticcheck
 }
 
 // AddPreStartHook add a prestart hook into g.Config.Hooks.Prestart.
 func (g *Generator) AddPreStartHook(preStartHook rspec.Hook) {
 	g.initConfigHooks()
-	g.Config.Hooks.Prestart = append(g.Config.Hooks.Prestart, preStartHook)
+	g.Config.Hooks.Prestart = append(g.Config.Hooks.Prestart, preStartHook) //nolint:staticcheck
 }
 
 // ClearPostStopHooks clear g.Config.Hooks.Poststop.
diff --git a/generate/seccomp/seccomp_default.go b/generate/seccomp/seccomp_default.go
@@ -3,7 +3,6 @@ package seccomp
 import (
 	"runtime"
 
-	"github.com/opencontainers/runtime-spec/specs-go"
 	rspec "github.com/opencontainers/runtime-spec/specs-go"
 )
 
@@ -31,7 +30,7 @@ func arches() []rspec.Arch {
 }
 
 // DefaultProfile defines the whitelist for the default seccomp profile.
-func DefaultProfile(rs *specs.Spec) *rspec.LinuxSeccomp {
+func DefaultProfile(rs *rspec.Spec) *rspec.LinuxSeccomp {
 	syscalls := []rspec.LinuxSyscall{
 		{
 			Names: []string{
diff --git a/generate/seccomp/seccomp_default_linux.go b/generate/seccomp/seccomp_default_linux.go
@@ -1,5 +1,4 @@
 //go:build linux
-// +build linux
 
 package seccomp
 
diff --git a/generate/seccomp/seccomp_default_unsupported.go b/generate/seccomp/seccomp_default_unsupported.go
@@ -1,5 +1,4 @@
 //go:build !linux
-// +build !linux
 
 package seccomp
 
diff --git a/validate/validate.go b/validate/validate.go
@@ -274,7 +274,7 @@ func (v *Validator) CheckHooks() (errs error) {
 	}
 
 	if v.spec.Hooks != nil {
-		errs = multierror.Append(errs, v.checkEventHooks("prestart", v.spec.Hooks.Prestart, v.HostSpecific))
+		errs = multierror.Append(errs, v.checkEventHooks("prestart", v.spec.Hooks.Prestart, v.HostSpecific)) //nolint:staticcheck
 		errs = multierror.Append(errs, v.checkEventHooks("poststart", v.spec.Hooks.Poststart, v.HostSpecific))
 		errs = multierror.Append(errs, v.checkEventHooks("poststop", v.spec.Hooks.Poststop, v.HostSpecific))
 	}
@@ -440,7 +440,7 @@ func (v *Validator) CheckCapabilities() (errs error) {
 		if effective && !permitted {
 			errs = multierror.Append(errs, fmt.Errorf("effective capability %q is not allowed, as it's not permitted", capability))
 		}
-		if ambient && !(permitted && inheritable) {
+		if ambient && (!permitted || !inheritable) {
 			errs = multierror.Append(errs, fmt.Errorf("ambient capability %q is not allowed, as it's not permitted and inheribate", capability))
 		}
 	}
@@ -718,21 +718,22 @@ func (v *Validator) rlimitValid(rlimit rspec.POSIXRlimit) (errs error) {
 		errs = multierror.Append(errs, fmt.Errorf("hard limit of rlimit %s should not be less than soft limit", rlimit.Type))
 	}
 
-	if v.platform == "linux" {
+	switch v.platform {
+	case "linux":
 		for _, val := range linuxRlimits {
 			if val == rlimit.Type {
 				return
 			}
 		}
 		errs = multierror.Append(errs, specerror.NewError(specerror.PosixProcRlimitsTypeValueError, fmt.Errorf("rlimit type %q may not be valid", rlimit.Type), v.spec.Version))
-	} else if v.platform == "solaris" {
+	case "solaris":
 		for _, val := range posixRlimits {
 			if val == rlimit.Type {
 				return
 			}
 		}
 		errs = multierror.Append(errs, specerror.NewError(specerror.PosixProcRlimitsTypeValueError, fmt.Errorf("rlimit type %q may not be valid", rlimit.Type), v.spec.Version))
-	} else {
+	default:
 		logrus.Warnf("process.rlimits validation not yet implemented for platform %q", v.platform)
 	}
 
diff --git a/validate/validate_linux.go b/validate/validate_linux.go
@@ -1,5 +1,4 @@
 //go:build linux
-// +build linux
 
 package validate
 
diff --git a/validate/validate_unsupported.go b/validate/validate_unsupported.go
@@ -1,5 +1,4 @@
 //go:build !linux
-// +build !linux
 
 package validate
 
diff --git a/validation/hostname/hostname.go b/validation/hostname/hostname.go
@@ -30,7 +30,7 @@ func main() {
 	t.Header(0)
 	defer t.AutoPlan()
 
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		t.Skip(1, "linux-specific namespace test")
 	}
 
diff --git a/validation/linux_cgroups_blkio/linux_cgroups_blkio.go b/validation/linux_cgroups_blkio/linux_cgroups_blkio.go
@@ -50,7 +50,7 @@ func testBlkioCgroups(rate uint64, isEmpty bool) error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_cpus/linux_cgroups_cpus.go b/validation/linux_cgroups_cpus/linux_cgroups_cpus.go
@@ -119,7 +119,7 @@ func testEmptyCPU() error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_hugetlb/linux_cgroups_hugetlb.go b/validation/linux_cgroups_hugetlb/linux_cgroups_hugetlb.go
@@ -88,7 +88,7 @@ func testWrongHugetlb() error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_memory/linux_cgroups_memory.go b/validation/linux_cgroups_memory/linux_cgroups_memory.go
@@ -10,7 +10,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_network/linux_cgroups_network.go b/validation/linux_cgroups_network/linux_cgroups_network.go
@@ -98,7 +98,7 @@ func testNetworkCgroups() error {
 }
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Fatal(fmt.Errorf("linux-specific cgroup test"))
 	}
 
diff --git a/validation/linux_cgroups_relative_cpus/linux_cgroups_relative_cpus.go b/validation/linux_cgroups_relative_cpus/linux_cgroups_relative_cpus.go
@@ -11,7 +11,7 @@ func main() {
 	var shares uint64 = 1024
 	var period uint64 = 100000
 	var quota int64 = 50000
-	var cpus, mems string = "0-1", "0"
+	var cpus, mems = "0-1", "0"
 
 	t := tap.New()
 	t.Header(0)
diff --git a/validation/linux_ns_itype/linux_ns_itype.go b/validation/linux_ns_itype/linux_ns_itype.go
@@ -118,7 +118,7 @@ func main() {
 	t := tap.New()
 	t.Header(0)
 
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		t.Skip(1, "linux-specific namespace test")
 	}
 
diff --git a/validation/linux_ns_nopath/linux_ns_nopath.go b/validation/linux_ns_nopath/linux_ns_nopath.go
@@ -119,7 +119,7 @@ func main() {
 	t := tap.New()
 	t.Header(0)
 
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		t.Skip(1, "linux-specific namespace test")
 	}
 
diff --git a/validation/linux_ns_path/linux_ns_path.go b/validation/linux_ns_path/linux_ns_path.go
@@ -148,7 +148,7 @@ func main() {
 	}
 
 	for _, c := range cases {
-		if "linux" != runtime.GOOS {
+		if runtime.GOOS != "linux" {
 			t.Skip(1, fmt.Sprintf("linux-specific namespace test: %s", c))
 		}
 
diff --git a/validation/linux_ns_path_type/linux_ns_path_type.go b/validation/linux_ns_path_type/linux_ns_path_type.go
@@ -93,7 +93,7 @@ func main() {
 	}
 
 	for _, c := range cases {
-		if "linux" != runtime.GOOS {
+		if runtime.GOOS != "linux" {
 			t.Skip(1, fmt.Sprintf("linux-specific namespace test: %s", c))
 		}
 
diff --git a/validation/process_capabilities/process_capabilities.go b/validation/process_capabilities/process_capabilities.go
@@ -8,7 +8,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Skip("linux-specific process.capabilities test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/process_capabilities_fail/process_capabilities_fail.go b/validation/process_capabilities_fail/process_capabilities_fail.go
@@ -11,7 +11,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS {
+	if runtime.GOOS != "linux" {
 		util.Skip("linux-specific process.capabilities test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/process_rlimits/process_rlimits.go b/validation/process_rlimits/process_rlimits.go
@@ -8,7 +8,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS && "solaris" != runtime.GOOS {
+	if runtime.GOOS != "linux" && runtime.GOOS != "solaris" {
 		util.Skip("POSIX-specific process.rlimits test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/process_rlimits_fail/process_rlimits_fail.go b/validation/process_rlimits_fail/process_rlimits_fail.go
@@ -11,7 +11,7 @@ import (
 )
 
 func main() {
-	if "linux" != runtime.GOOS && "solaris" != runtime.GOOS {
+	if runtime.GOOS != "linux" && runtime.GOOS != "solaris" {
 		util.Skip("POSIX-specific process.rlimits test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/root_readonly_true/root_readonly_true.go b/validation/root_readonly_true/root_readonly_true.go
@@ -8,7 +8,7 @@ import (
 )
 
 func main() {
-	if "windows" == runtime.GOOS {
+	if runtime.GOOS == "windows" {
 		util.Skip("non-Windows root.readonly test", map[string]string{"OS": runtime.GOOS})
 		os.Exit(0)
 	}
diff --git a/validation/util/linux_resources_memory.go b/validation/util/linux_resources_memory.go
@@ -31,11 +31,11 @@ func ValidateLinuxResourcesMemory(config *rspec.Spec, t *tap.T, state *rspec.Sta
 	t.Ok(*lm.Swap == *config.Linux.Resources.Memory.Swap, "memory swap is set correctly")
 	t.Diagnosticf("expect: %d, actual: %d", *config.Linux.Resources.Memory.Swap, *lm.Reservation)
 
-	t.Ok(*lm.Kernel == *config.Linux.Resources.Memory.Kernel, "memory kernel is set correctly")
-	t.Diagnosticf("expect: %d, actual: %d", *config.Linux.Resources.Memory.Kernel, *lm.Kernel)
+	t.Ok(*lm.Kernel == *config.Linux.Resources.Memory.Kernel, "memory kernel is set correctly") //nolint:staticcheck
+	t.Diagnosticf("expect: %d, actual: %d", *config.Linux.Resources.Memory.Kernel, *lm.Kernel) //nolint:staticcheck
 
 	t.Ok(*lm.KernelTCP == *config.Linux.Resources.Memory.KernelTCP, "memory kernelTCP is set correctly")
-	t.Diagnosticf("expect: %d, actual: %d", *config.Linux.Resources.Memory.KernelTCP, *lm.Kernel)
+	t.Diagnosticf("expect: %d, actual: %d", *config.Linux.Resources.Memory.KernelTCP, *lm.Kernel) //nolint:staticcheck
 
 	t.Ok(*lm.Swappiness == *config.Linux.Resources.Memory.Swappiness, "memory swappiness is set correctly")
 	t.Diagnosticf("expect: %d, actual: %d", *config.Linux.Resources.Memory.Swappiness, *lm.Swappiness)

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,7 @@ func (cg CgroupV1) GetMemoryData(pid int, cgPath string) (rspec.LinuxMemory, e`
`539`	`539`	`return nil, err`
`540`	`540`	`}`
`541`	`541`	`kernelLimit := res`
`542`		`- lm.Kernel = &kernelLimit`
	`542`	`+ lm.Kernel = &kernelLimit //nolint:staticcheck`
`543`	`543`	`case 4:`
`544`	`544`	`res, err := strconv.ParseInt(strings.TrimSpace(string(contents)), 10, 64)`
`545`	`545`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,8 @@ func New(os string) (generator Generator, err error) {`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`- if os == "linux" {`
	`95`	`+ switch os {`
	`96`	`+ case "linux":`
`96`	`97`	`config.Process.Capabilities = &rspec.LinuxCapabilities{`
`97`	`98`	`Bounding: []string{`
`98`	`99`	`"CAP_CHOWN",`
`@@ -241,7 +242,7 @@ func New(os string) (generator Generator, err error) {`
`241`	`242`	`},`
`242`	`243`	`Seccomp: seccomp.DefaultProfile(&config),`
`243`	`244`	`}`
`244`		`- } else if os == "freebsd" {`
	`245`	`+ case "freebsd":`
`245`	`246`	`config.Mounts = []rspec.Mount{`
`246`	`247`	`{`
`247`	`248`	`Destination: "/dev",`
`@@ -597,7 +598,7 @@ func (g *Generator) ClearProcessAdditionalGids() {`
`597`	`598`	`}`
`598`	`599`
`599`	`600`	`// AddProcessAdditionalGid adds an additional gid into g.Config.Process.AdditionalGids.`
`600`		`-func (g *Generator) AddProcessAdditionalGid(gid uint32) {`
	`601`	`+func (g *Generator) AddProcessAdditionalGid(gid uint32) { //nolint:staticcheck`
`601`	`602`	`g.initConfigProcess()`
`602`	`603`	`for _, group := range g.Config.Process.User.AdditionalGids {`
`603`	`604`	`if group == gid {`
`@@ -915,7 +916,7 @@ func (g *Generator) SetLinuxResourcesMemorySwap(swap int64) {`
`915`	`916`	`// SetLinuxResourcesMemoryKernel sets g.Config.Linux.Resources.Memory.Kernel.`
`916`	`917`	`func (g *Generator) SetLinuxResourcesMemoryKernel(kernel int64) {`
`917`	`918`	`g.initConfigLinuxResourcesMemory()`
`918`		`- g.Config.Linux.Resources.Memory.Kernel = &kernel`
	`919`	`+ g.Config.Linux.Resources.Memory.Kernel = &kernel //nolint:staticcheck`
`919`	`920`	`}`
`920`	`921`
`921`	`922`	`// SetLinuxResourcesMemoryKernelTCP sets g.Config.Linux.Resources.Memory.KernelTCP.`
`@@ -1066,13 +1067,13 @@ func (g *Generator) ClearPreStartHooks() {`
`1066`	`1067`	`if g.Config == nil \|\| g.Config.Hooks == nil {`
`1067`	`1068`	`return`
`1068`	`1069`	`}`
`1069`		`- g.Config.Hooks.Prestart = []rspec.Hook{}`
	`1070`	`+ g.Config.Hooks.Prestart = []rspec.Hook{} //nolint:staticcheck`
`1070`	`1071`	`}`
`1071`	`1072`
`1072`	`1073`	`// AddPreStartHook add a prestart hook into g.Config.Hooks.Prestart.`
`1073`	`1074`	`func (g *Generator) AddPreStartHook(preStartHook rspec.Hook) {`
`1074`	`1075`	`g.initConfigHooks()`
`1075`		`- g.Config.Hooks.Prestart = append(g.Config.Hooks.Prestart, preStartHook)`
	`1076`	`+ g.Config.Hooks.Prestart = append(g.Config.Hooks.Prestart, preStartHook) //nolint:staticcheck`
`1076`	`1077`	`}`
`1077`	`1078`
`1078`	`1079`	`// ClearPostStopHooks clear g.Config.Hooks.Poststop.`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ package seccomp`
`3`	`3`	`import (`
`4`	`4`	`"runtime"`
`5`	`5`
`6`		`- "github.com/opencontainers/runtime-spec/specs-go"`
`7`	`6`	`rspec "github.com/opencontainers/runtime-spec/specs-go"`
`8`	`7`	`)`
`9`	`8`
`@@ -31,7 +30,7 @@ func arches() []rspec.Arch {`
`31`	`30`	`}`
`32`	`31`
`33`	`32`	`// DefaultProfile defines the whitelist for the default seccomp profile.`
`34`		`-func DefaultProfile(rs specs.Spec) rspec.LinuxSeccomp {`
	`33`	`+func DefaultProfile(rs rspec.Spec) rspec.LinuxSeccomp {`
`35`	`34`	`syscalls := []rspec.LinuxSyscall{`
`36`	`35`	`{`
`37`	`36`	`Names: []string{`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`//go:build linux`
`2`		`-// +build linux`
`3`	`2`
`4`	`3`	`package seccomp`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`//go:build !linux`
`2`		`-// +build !linux`
`3`	`2`
`4`	`3`	`package seccomp`
`5`	`4`
Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ func (v *Validator) CheckHooks() (errs error) {`
`274`	`274`	`}`
`275`	`275`
`276`	`276`	`if v.spec.Hooks != nil {`
`277`		`- errs = multierror.Append(errs, v.checkEventHooks("prestart", v.spec.Hooks.Prestart, v.HostSpecific))`
	`277`	`+ errs = multierror.Append(errs, v.checkEventHooks("prestart", v.spec.Hooks.Prestart, v.HostSpecific)) //nolint:staticcheck`
`278`	`278`	`errs = multierror.Append(errs, v.checkEventHooks("poststart", v.spec.Hooks.Poststart, v.HostSpecific))`
`279`	`279`	`errs = multierror.Append(errs, v.checkEventHooks("poststop", v.spec.Hooks.Poststop, v.HostSpecific))`
`280`	`280`	`}`
`@@ -440,7 +440,7 @@ func (v *Validator) CheckCapabilities() (errs error) {`
`440`	`440`	`if effective && !permitted {`
`441`	`441`	`errs = multierror.Append(errs, fmt.Errorf("effective capability %q is not allowed, as it's not permitted", capability))`
`442`	`442`	`}`
`443`		`- if ambient && !(permitted && inheritable) {`
	`443`	`+ if ambient && (!permitted \|\| !inheritable) {`
`444`	`444`	`errs = multierror.Append(errs, fmt.Errorf("ambient capability %q is not allowed, as it's not permitted and inheribate", capability))`
`445`	`445`	`}`
`446`	`446`	`}`
`@@ -718,21 +718,22 @@ func (v *Validator) rlimitValid(rlimit rspec.POSIXRlimit) (errs error) {`
`718`	`718`	`errs = multierror.Append(errs, fmt.Errorf("hard limit of rlimit %s should not be less than soft limit", rlimit.Type))`
`719`	`719`	`}`
`720`	`720`
`721`		`- if v.platform == "linux" {`
	`721`	`+ switch v.platform {`
	`722`	`+ case "linux":`
`722`	`723`	`for _, val := range linuxRlimits {`
`723`	`724`	`if val == rlimit.Type {`
`724`	`725`	`return`
`725`	`726`	`}`
`726`	`727`	`}`
`727`	`728`	`errs = multierror.Append(errs, specerror.NewError(specerror.PosixProcRlimitsTypeValueError, fmt.Errorf("rlimit type %q may not be valid", rlimit.Type), v.spec.Version))`
`728`		`- } else if v.platform == "solaris" {`
	`729`	`+ case "solaris":`
`729`	`730`	`for _, val := range posixRlimits {`
`730`	`731`	`if val == rlimit.Type {`
`731`	`732`	`return`
`732`	`733`	`}`
`733`	`734`	`}`
`734`	`735`	`errs = multierror.Append(errs, specerror.NewError(specerror.PosixProcRlimitsTypeValueError, fmt.Errorf("rlimit type %q may not be valid", rlimit.Type), v.spec.Version))`
`735`		`- } else {`
	`736`	`+ default:`
`736`	`737`	`logrus.Warnf("process.rlimits validation not yet implemented for platform %q", v.platform)`
`737`	`738`	`}`
`738`	`739`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ func main() {`
`30`	`30`	`t.Header(0)`
`31`	`31`	`defer t.AutoPlan()`
`32`	`32`
`33`		`- if "linux" != runtime.GOOS {`
	`33`	`+ if runtime.GOOS != "linux" {`
`34`	`34`	`t.Skip(1, "linux-specific namespace test")`
`35`	`35`	`}`
`36`	`36`