Skip to content

Strip back #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Sukh-P merged 5 commits into from
Jun 23, 2025
Merged

Strip back #377

Sukh-P merged 5 commits into from
Jun 23, 2025

Conversation

@dfulu
Copy link
Member

@dfulu dfulu commented May 12, 2025 •
edited
Loading

Pull Request

Description

Remove lots of code that we no longer use

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Sukh-P
Sukh-P approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@Sukh-P Sukh-P left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much for removing ~2000 LoC! 😅

@Sukh-P
Copy link
Member

Sukh-P commented May 13, 2025

I think as previously mentioned could possibly also strip out the wind_multimodal.py file, don't think it adds anything extra as an example

@Sukh-P Sukh-P merged commit d868762 into main Jun 23, 2025
3 checks passed
@Sukh-P Sukh-P deleted the remove_unused branch June 23, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sukh-P Sukh-P Sukh-P approved these changes

@AUdaltsova AUdaltsova Awaiting requested review from AUdaltsova

@felix-e-h-p felix-e-h-p Awaiting requested review from felix-e-h-p

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dfulu @Sukh-P