Skip to content

Commit f0e5de9

Browse files
ewalkusxwilliamspatrick
authored andcommitted
unit-test: Remove UBSAN_OPTIONS=halt_on_error=1
Setting `UBSAN_OPTIONS=halt_on_error=1` here makes adding the `UBSAN_OPTION` environment variable ineffective (like `suppressions=ubsan.supp` or `print_summary=1`). This environment variable is always overwritten. The mechanism that makes UBSAN kill tests is no longer needed when using meson version 1.3.0 or higher mesonbuild/meson@7b7d2e060b where default ``` UBSAN_OPTION=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 ``` Resolves: #43 Tested: - Run `run-unit-test-docker.sh` without setting env variable, with `invalid vptr` error - tests failed with more info in logs (stack trace, summary) - Run `run-unit-test-docker.sh` with setting env variable `UBSAN_OPTION=suppressions=ubsan.supp` with suppression for vptr check and with bug location - tests passed Change-Id: I64eb799645dbc9cde4b7ee75098b641ebe30a5a4 Signed-off-by: Ewelina Walkusz <[email protected]>
1 parent 1ef5c60 commit f0e5de9

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

scripts/unit-test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,6 @@ def analyze(self):
11001100
"--print-errorlogs",
11011101
"--logbase",
11021102
"testlog-ubasan",
1103-
env=os.environ | {"UBSAN_OPTIONS": "halt_on_error=1"},
11041103
)
11051104
# TODO: Fix memory sanitizer
11061105
# check_call_cmd('meson', 'configure', 'build',

0 commit comments

Comments
 (0)