Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor source ids are not created equally across the different fetchers #21

Open
caparker opened this issue Oct 5, 2022 · 0 comments
Open

Comments

@caparker
Copy link
Collaborator

caparker commented Oct 5, 2022

The source id is used to match measurement data to the sensor in the openaq db and they are not being done the same which could cause issues if there is ever the case where two different sources have the same source site id value.

For example, the purpleair fetcher provides this format
PurpleAir-35053-10.0_um_count, which is
SourceName-SourceSiteId-SourceParameterAndUnitsName
Whereas clarity provides
AX5CC5K1-pm10, which is
SourceSiteName-OpenAQParameterName

I propose that we do the following

  • Exchange the dashes for forward slashes
  • Always include the SourceName
  • Always use SourceSiteId instead of SourceSiteName
  • Aways use the OpenAQParameterAndUnitsName
  • Include the SourceSystemId or a suitable identifier that could be derived from the source

Which would look like this
SourceName/SourceSystemId/SourceSiteId/OpenAQParameterAndUnits
E.g.
PurpleAir/PAII/35053/pm10count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant