Fix #133 Add React Native Support #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RN shim with react-native-webrtc peer dependency - Shims now export webRTC classes, and implementation imports these instead of globals - Only call document in browser environment
🦋 Changeset detectedLatest commit: 15665c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
15 tasks
seratch
added
enhancement
dkundel-openai
requested changes
Jul 15, 2025
| registerGlobals, | ||
| } from 'react-native-webrtc'; | ||
|
|
||
| registerGlobals(); |
There was a problem hiding this comment.
I don't think we are using the globals which is good so I would say let's drop the registerGlobals() that way it's still up to the implementor if they want to register them for additional use cases rather than us magically importing them
| import type { EventEmitterEvents, Timeout, Timer } from './interface'; | ||
|
|
||
| import { EventEmitter as NodeEventEmitter } from 'events'; | ||
| import 'event-target-shim'; |
There was a problem hiding this comment.
Do we need EventTarget as a shim in React Native?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
What's New
agents-realtime: Now we export the relevant webRTC classes for each shim,react-native-webrtcis a peer dependency for the new RN shim.agents-core: I usedevent-target-shim,events,@ungap/structured-cloneandreact-native-uuidfor polyfills. I figured that because they're in the shim, they will get tree-shaken for other environments.How It Works
WebRTC classes are now exposed through the shims with react-native-webrtc as a peer dependency. Users don't need to change anything about how they use the SDK; it just works.
Testing
I've tested this thoroughly in a create-expo-app starter project and everything works great - WebRTC connections, audio handling, etc. I didn't add integration tests here since that seemed like it might be too much setup complexity for the repo, but I'm totally happy to create a standalone example repo if the maintainers would find that helpful!
The React Native shim automatically calls
registerGlobals()when imported, which sets up the WebRTC globals. I believe that users could still callregisterGlobals()within their RN app again if they wanted to. In my testing, everything worked without needing to callregisterGlobals()in the app code.Notes / Improvements
Note that when running in expo, I see:
These warnings are due to the fact that there is some circular importing going on where the shims are imported into mcp.ts, but mcp also imports from the shims. I figured this wasn't in scope for this PR.