Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change greetd package to UsrEtc config #58

Open
denisok opened this issue Jun 1, 2022 · 6 comments
Open

change greetd package to UsrEtc config #58

denisok opened this issue Jun 1, 2022 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@denisok
Copy link
Contributor

denisok commented Jun 1, 2022

Change config location to /usr/etc for greetd in openSUSE.

https://todo.sr.ht/~kennylevinsen/greetd/20

actually we can pass --config as the parameter in service file:
https://git.sr.ht/~kennylevinsen/greetd/tree/master/item/greetd.service#L9

to support /usr/etc config instead of /etc/: https://build.opensuse.org/package/show/X11:Wayland/greetd

@denisok denisok added the enhancement New feature or request label Jun 1, 2022
@denisok denisok added the good first issue Good for newcomers label Jun 1, 2022
@denisok
Copy link
Contributor Author

denisok commented Jul 10, 2022

@danyspin97 maybe you could help with this one ?

@danyspin97
Copy link
Collaborator

Sure! :) The thing with passing --config /usr/etc/greetd/greetd.conf is that a user has no way to override that without modifying system files and this is definitely not what we want. I think we should document this in the tracker as well, as an argument against --config and a reason for upstream to accept our patch.

@krishjainx
Copy link
Contributor

@denisok This seems like a non-issue or an easily fixable/documentable quirk/issue. How should we proceed?

@denisok
Copy link
Contributor Author

denisok commented Jan 18, 2024

It is nice to have for the MicroOS and similar OSes where /etc is reserved to the base OS. It would be cool to have all openSUSEway config files under /usr/etc instead.

Just good improvement, but not a critical one.

@LakshayPuhal
Copy link

I would like to work on this issue.

@FilippoBonazziSUSE
Copy link
Collaborator

I think greetd and associated greeters (gtkgreet, ...) would need to be patched to look for files under /etc/greetd first (current behaviour), then under /usr/etc/greetd (see https://en.opensuse.org/openSUSE:Packaging_UsrEtc).

greetd would need to be patched when looking for /etc/greetd/config.toml, gtkgreet would need to be patched when looking for /etc/greetd/environments. Perhaps there are others.

This could be done in OBS right away, and proposed to upstream in parallel.

Then we could provide our files under /usr/etc as %config (without noreplace) without fear of messing with the user-managed files under /etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants