refactored the null empty condition amd list iteration with foreach

Author: NiranjanNlc

core/data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/AccountMapper.kt

@@ -10,21 +10,16 @@ class AccountMapper @Inject constructor(private val currencyMapper: CurrencyMapp
     fun transform(clientAccounts: ClientAccounts?): List<Account> {
         val accountList = mutableListOf<Account>()
 
-        if (clientAccounts != null
-            && !clientAccounts.savingsAccounts.isNullOrEmpty()) {
-
-            for (savingAccount in clientAccounts.savingsAccounts) {
-                val account = Account().apply {
-                    name = savingAccount.productName
-                    number = savingAccount.accountNo
-                    id = savingAccount.id
-                    balance = savingAccount.accountBalance
-                    currency = currencyMapper.transform(savingAccount.currency)
-                    productId = savingAccount.productId.toLong()
-                }
-
-                accountList.add(account)
+        clientAccounts?.savingsAccounts?.forEach { savingAccount ->
+            val account = Account().apply {
+                name = savingAccount.productName
+                number = savingAccount.accountNo
+                id = savingAccount.id
+                balance = savingAccount.accountBalance
+                currency = currencyMapper.transform(savingAccount.currency)
+                productId = savingAccount.productId.toLong()
             }
+            accountList.add(account)
         }
         return accountList
     }

core/data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/CurrencyMapper.kt

@@ -2,14 +2,15 @@ package org.mifos.mobilewallet.core.data.fineract.entity.mapper
 
 import com.mifos.mobilewallet.model.entity.accounts.savings.Currency
 import javax.inject.Inject
+import com.mifos.mobilewallet.model.domain.Currency as DomainCurrency
 
 /**
  * Created by naman on 17/8/17.
  */
 class CurrencyMapper @Inject internal constructor() {
-    fun transform(savingsCurrency: Currency): com.mifos.mobilewallet.model.domain.Currency {
-        val currency: com.mifos.mobilewallet.model.domain.Currency =
-            com.mifos.mobilewallet.model.domain.Currency()
+    fun transform(savingsCurrency: Currency): DomainCurrency {
+        val currency: DomainCurrency =
+            DomainCurrency()
         currency.code = savingsCurrency.code
         currency.displayLabel = savingsCurrency.displayLabel
         currency.displaySymbol = savingsCurrency.displaySymbol

core/data/src/main/java/org/mifos/mobilewallet/core/data/fineract/entity/mapper/TransactionMapper.kt

@@ -12,10 +12,8 @@ class TransactionMapper @Inject constructor(private val currencyMapper: Currency
     fun transformTransactionList(savingsWithAssociations: SavingsWithAssociations?): List<Transaction> {
         val transactionList = ArrayList<Transaction>()
 
-        if (savingsWithAssociations != null && !savingsWithAssociations.transactions.isNullOrEmpty()) {
-            for (transactions in savingsWithAssociations.transactions) {
-                transactionList.add(transformInvoice(transactions))
-            }
+        savingsWithAssociations?.transactions?.forEach { transaction ->
+            transactionList.add(transformInvoice(transaction))
         }
         return transactionList
     }

core/data/src/main/java/org/mifos/mobilewallet/core/domain/usecase/account/TransferFunds.kt

@@ -111,7 +111,7 @@ class TransferFunds @Inject constructor( private val apiRepository: FineractRepo
 
                 override fun onNext(clientAccounts: ClientAccounts) {
                     val accounts = clientAccounts.savingsAccounts
-                    if (accounts != null && accounts.isNotEmpty()) {
+                    if (!accounts.isNullOrEmpty()) {
                         var walletAccount: SavingAccount? = null
                         for (account in accounts) {
                             if (account.productId == Constants.WALLET_ACCOUNT_SAVINGS_PRODUCT_ID) {