refactor #1537: migrated faq screen to compose

Author: PratyushSingh07

Diff for: core/designsystem/src/main/java/org/mifos/mobilewallet/mifospay/designsystem/component/FaqItemScreen.kt

@@ -17,8 +17,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
+import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.scale
@@ -30,10 +32,8 @@ import androidx.compose.ui.unit.dp
 fun FaqItemScreen(
     question: String?,
     answer: String?,
-    onItemSelected: (Int) -> Unit,
-    index: Int
 ) {
-    val isSelected = remember { mutableStateOf(false) }
+    var isSelected by remember { mutableStateOf(false) }
 
     Column(
         modifier = Modifier
@@ -43,8 +43,7 @@ fun FaqItemScreen(
         Row(
             modifier = Modifier
                 .clickable {
-                    isSelected.value = !isSelected.value
-                    onItemSelected.invoke(index)
+                    isSelected = !isSelected
                 }
                 .padding(vertical = 8.dp),
             verticalAlignment = Alignment.CenterVertically
@@ -63,12 +62,12 @@ fun FaqItemScreen(
                 contentDescription = "drop down",
                 tint = Color.Black,
                 modifier = Modifier
-                    .scale(1f, if (isSelected.value) -1f else 1f)
+                    .scale(1f, if (isSelected) -1f else 1f)
             )
         }
 
         AnimatedVisibility(
-            visible = isSelected.value,
+            visible = isSelected,
             enter = fadeIn() + expandVertically(
                 animationSpec = spring(
                     stiffness = Spring.StiffnessMedium

Diff for: mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQ.kt

@@ -2,6 +2,5 @@ package org.mifos.mobilewallet.mifospay.faq.ui
 
 data class FAQ(
     var question: Int,
-
     var answer: Int? = null,
 )

Diff for: mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FAQActivity.kt

@@ -2,11 +2,7 @@ package org.mifos.mobilewallet.mifospay.faq.ui
 
 import android.os.Bundle
 import androidx.activity.compose.setContent
-import androidx.activity.viewModels
-import androidx.compose.runtime.MutableState
-import androidx.compose.runtime.mutableIntStateOf
 import org.mifos.mobilewallet.mifospay.base.BaseActivity
-import org.mifos.mobilewallet.mifospay.faq.presenter.FAQViewModel
 import org.mifos.mobilewallet.mifospay.theme.MifosTheme
 
 /**
@@ -15,26 +11,17 @@ import org.mifos.mobilewallet.mifospay.theme.MifosTheme
  * @author ankur
  * @since 11/July/2018
  */
-class FAQActivity : BaseActivity() {
-
-    private var selectedFaqPosition: MutableState<Int> = mutableIntStateOf(-1)
 
-    private val faqViewModel: FAQViewModel by viewModels()
+class FAQActivity : BaseActivity() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContent {
             MifosTheme {
                 FaqScreen(
-                    faqViewModel = faqViewModel,
-                    navigateBack = { onBackPressedDispatcher.onBackPressed() },
-                    updateFaqPosition = { updateSelectedFaqPosition(it) }
+                    navigateBack = { onBackPressedDispatcher.onBackPressed() }
                 )
             }
         }
     }
-
-    private fun updateSelectedFaqPosition(position: Int) {
-        selectedFaqPosition.value = if (selectedFaqPosition.value == position) -1 else position
-    }
 }

Diff for: mifospay/src/main/java/org/mifos/mobilewallet/mifospay/faq/ui/FaqScreen.kt

@@ -18,8 +18,7 @@ import org.mifos.mobilewallet.mifospay.faq.presenter.FAQViewModel
 @Composable
 fun FaqScreen(
     navigateBack: () -> Unit,
-    faqViewModel: FAQViewModel = hiltViewModel(),
-    updateFaqPosition: (Int) -> Unit,
+    faqViewModel: FAQViewModel = hiltViewModel()
 ) {
     Column(modifier = Modifier.fillMaxSize()) {
         MifosTopBar(
@@ -33,9 +32,7 @@ fun FaqScreen(
             itemsIndexed(items = faqViewModel.getFAQ()) { index, faqItem ->
                 FaqItemScreen(
                     question = stringResource(id = faqItem.question),
-                    answer = faqItem.answer?.let { stringResource(id = it) },
-                    onItemSelected = { position -> updateFaqPosition(position) },
-                    index = index
+                    answer = faqItem.answer?.let { stringResource(id = it) }
                 )
             }
         }
@@ -45,5 +42,5 @@ fun FaqScreen(
 @Preview(showSystemUi = true)
 @Composable
 fun FaqScreenPreview() {
-    FaqScreen({}, hiltViewModel(), {})
+    FaqScreen({}, hiltViewModel())
 }