Skip to content

Discontinue prometheus crate? #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cijothomas opened this issue Dec 18, 2024 · 4 comments · Fixed by #2831
Closed

Discontinue prometheus crate? #2451

cijothomas opened this issue Dec 18, 2024 · 4 comments · Fixed by #2831

Comments

@cijothomas
Copy link
Member

Given more and more native support from Prometheus to ingest OTLP, wondering if we should keep publishing the prometheus crate?
https://prometheus.io/blog/2024/11/14/prometheus-3-0/#otlp-support

@cijothomas
Copy link
Member Author

Related: #1551 and #2769

I'd vote to mark this crate as deprecated in the coming release, and remove it fully. We can bring it back, when we have the bandwidth to rewrite it using the official prometheus crate and also avoiding the protobuf dependency which seem to be unmaintained (https://github.com/stepancheg/rust-protobuf/?tab=readme-ov-file#help)

@cijothomas
Copy link
Member Author

@open-telemetry/rust-maintainers Do you see any concerns with the above? Happy to discuss ideas, but we should not be shipping crates that cannot be easily maintained/patched due to dependencies on unmaintained (or less actively maintained) crates IMHO.

@cijothomas cijothomas added this to the 0.29 milestone Mar 17, 2025
@lalitb
Copy link
Member

lalitb commented Mar 17, 2025

There have been contributions from outside to keep it in-sync with the new OTel releases. We can also continue that as long as we just do the publish. But I am also good with removing it altogether if all agree.

@cijothomas
Copy link
Member Author

Yes those changes were relatively minor ones to keep up with upstream. but changing the dependencies is much bigger in scope and I think it'd be possibly require rewriting from scratch, and will be breaking changes for end users too
#1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants