We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening an issue to continue the discussion in #2128 (comment)
The text was updated successfully, but these errors were encountered:
I think relatively easy non-breaking solution would be to remove use of name: metadata from the otel macros, and introduce them later.
name:
macro_rules! otel_info { (name: $name:expr $(,)?) => { #[cfg(feature = "internal-logs")] { tracing::info!( target: env!("CARGO_PKG_NAME"), name = $name, ""); } #[cfg(not(feature = "internal-logs"))] { let _ = $name; // Compiler will optimize this out as it's unused. } };
Sorry, something went wrong.
but is there anything preventing us from requiring the minimum version of tracing that supports name?
Yes I think this should be fine to go with. I don't see the users to have concerns in bumping their tracing version.
lalitb
Successfully merging a pull request may close this issue.
Opening an issue to continue the discussion in #2128 (comment)
The text was updated successfully, but these errors were encountered: