Skip to content

tracing minimum version dependency #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cijothomas opened this issue Dec 2, 2024 · 3 comments · Fixed by #2418
Closed

tracing minimum version dependency #2373

cijothomas opened this issue Dec 2, 2024 · 3 comments · Fixed by #2418
Assignees
Milestone

Comments

@cijothomas
Copy link
Member

Opening an issue to continue the discussion in #2128 (comment)

@lalitb
Copy link
Member

lalitb commented Dec 3, 2024

I think relatively easy non-breaking solution would be to remove use of name: metadata from the otel macros, and introduce them later.

macro_rules! otel_info {
    (name: $name:expr $(,)?) => {
        #[cfg(feature = "internal-logs")]
        {
            tracing::info!(  target: env!("CARGO_PKG_NAME"), name = $name, "");
        }
        #[cfg(not(feature = "internal-logs"))]
        {
            let _ = $name; // Compiler will optimize this out as it's unused.
        }
    };

@cijothomas
Copy link
Member Author

but is there anything preventing us from requiring the minimum version of tracing that supports name?

@cijothomas cijothomas added this to the 0.28.0 milestone Dec 11, 2024
@lalitb
Copy link
Member

lalitb commented Dec 11, 2024

but is there anything preventing us from requiring the minimum version of tracing that supports name?

Yes I think this should be fine to go with. I don't see the users to have concerns in bumping their tracing version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants