-
Notifications
You must be signed in to change notification settings - Fork 523
Remove global error handler in favor of internal logs #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Saw issue with using |
That's a valid concern. I'm not entirely sure how we could achieve this directly, but will look it as potential improvement for future. For now, don't see this as a blocker, since the issue can be mitigated externally using a script to throttle the stderr output. |
For this specific one, I don't think there should be a log entry for channel full for each message. It is best exposed as an internal metric only. If a log is needed, it can be done at the shutdown time "N items were dropped due to buffer full"/similar. |
error
macro would be used for handling error, else theeprintln
would be used.The text was updated successfully, but these errors were encountered: