Skip to content

Add tests for appender-log crate #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cijothomas opened this issue Dec 1, 2023 · 2 comments · Fixed by #1501
Closed

Add tests for appender-log crate #1420

cijothomas opened this issue Dec 1, 2023 · 2 comments · Fixed by #1501
Labels
A-log Area: Issues related to logs good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers/approvers triage:accepted Has been triaged and accepted.

Comments

@cijothomas
Copy link
Member

appender for log crate has no tests today. Could borrow the approach from #1415 and some coverage.
@cijothomas cijothomas added good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers/approvers A-log Area: Issues related to logs triage:accepted Has been triaged and accepted. labels Dec 1, 2023
@mattbodd
Copy link
Contributor

@cijothomas I'm interested in taking this on

@mattbodd mattbodd mentioned this issue Jan 30, 2024
Merged
4 tasks
@mattbodd
Copy link
Contributor

@cijothomas I created a PR with an initial set of tests. Please let me know if these tests are meaningful and what you expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-log Area: Issues related to logs good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers/approvers triage:accepted Has been triaged and accepted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add initial tests to opentelemetry-appender-log mattbodd/opentelemetry-rust
2 participants
@cijothomas @mattbodd