Skip to content

Commit 9de34eb

Browse files
committed
opentelemetry: Disable events for NoopLogger
NoopLogger should be using a little resources as possible ideally none. This should help accomplish that.
1 parent 6221d8d commit 9de34eb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

opentelemetry/CHANGELOG.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
- [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Add experimental synchronous gauge. This is behind the feature flag, and can be enabled by enabling the feature `otel_unstable` for opentelemetry crate.
88

9-
- [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Guidelines to add new unstable/experimental features.
9+
- [#1410](https://github.com/open-telemetry/opentelemetry-rust/pull/1410) Guidelines to add new unstable/experimental features.
1010

1111
### Changed
1212

@@ -27,6 +27,8 @@ gains, and avoids `IndexMap` dependency. This affects `body` and `attributes` of
2727
`observe()` calls, and only accept a precreated `AttributeSet`
2828
value.
2929
[#1421](https://github.com/open-telemetry/opentelemetry-rust/pull/1421)
30+
- Turned off events for NoopLogger to save on operations
31+
[1455](https://github.com/open-telemetry/opentelemetry-rust/issues/1455)
3032

3133
### Removed
3234

opentelemetry/src/logs/noop.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@ impl Logger for NoopLogger {
4242
fn emit(&self, _record: LogRecord) {}
4343
#[cfg(feature = "logs_level_enabled")]
4444
fn event_enabled(&self, _level: super::Severity, _target: &str) -> bool {
45-
true
45+
false
4646
}
4747
}

0 commit comments

Comments
 (0)