Skip to content

Commit 35034f4

Browse files
committed
chore: formatting
1 parent 02e7a85 commit 35034f4

File tree

8 files changed

+49
-52
lines changed

8 files changed

+49
-52
lines changed

opentelemetry-otlp/tests/integration_test/src/images.rs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,21 @@ impl Image for Collector {
3636
impl Default for Collector {
3737
fn default() -> Self {
3838
Collector {
39-
volumes: HashMap::from([(
40-
"./otel-collector-config-2.yaml".into(),
41-
"/etc/otelcol/config.yaml".into(),
42-
),
39+
volumes: HashMap::from([
40+
(
41+
"./otel-collector-config-2.yaml".into(),
42+
"/etc/otelcol/config.yaml".into(),
43+
),
4344
(
4445
"./actual/traces.json".into(),
45-
"/testresults/traces.json".into()
46+
"/testresults/traces.json".into(),
4647
),
47-
(
48-
"./actual/logs.json".into(),
49-
"/testresults/logs.json".into()
50-
),
48+
("./actual/logs.json".into(), "/testresults/logs.json".into()),
5149
(
5250
"./actual/metrics.json".into(),
53-
"/testresults/metrics.json".into()
54-
)]),
51+
"/testresults/metrics.json".into(),
52+
),
53+
]),
5554
}
5655
}
5756
}

opentelemetry-otlp/tests/integration_test/src/lib.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@ use ctor::dtor;
33
pub mod images;
44
pub mod logs_asserter;
55
pub mod metrics_asserter;
6-
pub mod trace_asserter;
76
pub mod test_utils;
8-
7+
pub mod trace_asserter;

opentelemetry-otlp/tests/integration_test/src/metrics_asserter.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
use std::fs::File;
2-
use std::io::{BufReader, Read};
3-
use serde_json::Value;
1+
use crate::test_utils;
42
use anyhow::Result;
53
use ctor::dtor;
6-
use crate::test_utils;
4+
use serde_json::Value;
5+
use std::fs::File;
6+
use std::io::{BufReader, Read};
77

88
pub fn read_metrics_from_json(file: File) -> Result<Value> {
99
// Create a buffered reader for the file
@@ -18,7 +18,6 @@ pub fn read_metrics_from_json(file: File) -> Result<Value> {
1818
// Parse the contents into a JSON Value
1919
let metrics_data: Value = serde_json::from_str(&contents)?;
2020
Ok(metrics_data)
21-
2221
}
2322

2423
pub struct MetricsAsserter {

opentelemetry-otlp/tests/integration_test/src/test_utils.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
1+
use crate::images::Collector;
2+
use ctor::dtor;
23
use std::fs;
34
use std::fs::File;
45
use std::os::unix::fs::PermissionsExt;
5-
use std::sync::{Arc, OnceLock, Mutex};
6-
use ctor::dtor;
6+
use std::sync::{Arc, Mutex, OnceLock};
77
use testcontainers::clients::Cli;
88
use testcontainers::core::Port;
99
use testcontainers::{Container, RunnableImage};
10-
use crate::images::Collector;
1110

1211
// Static references for container management
1312
static COLLECTOR_ARC: OnceLock<Mutex<Option<Arc<Container<Collector>>>>> = OnceLock::new();
@@ -32,7 +31,6 @@ pub async fn start_collector_container() -> Arc<Container<'static, Collector>> {
3231
if let Some(container) = &*arc_guard {
3332
Arc::clone(container)
3433
} else {
35-
3634
// Make sure all our test data is mounted
3735
upsert_empty_file(METRICS_FILE);
3836
upsert_empty_file(TRACES_FILE);
@@ -75,4 +73,4 @@ pub fn stop_collector_container() {
7573
container.stop();
7674
println!("Collector container stopped.");
7775
}
78-
}
76+
}

opentelemetry-otlp/tests/integration_test/src/trace_asserter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1+
use anyhow::Result;
12
use opentelemetry_proto::tonic::trace::v1::{ResourceSpans, Span, TracesData};
23
use std::collections::{HashMap, HashSet};
34
use std::fmt::{Debug, Formatter};
45
use std::fs::File;
5-
use anyhow::Result;
66

77
// Given two ResourceSpans, assert that they are equal except for the timestamps
88
pub struct TraceAsserter {

opentelemetry-otlp/tests/integration_test/tests/logs.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#![cfg(unix)]
22

3+
use anyhow::Result;
4+
use ctor::dtor;
35
use integration_test_runner::logs_asserter::{read_logs_from_json, LogsAsserter};
6+
use integration_test_runner::test_utils;
47
use log::{info, Level};
58
use opentelemetry::KeyValue;
69
use opentelemetry_appender_log::OpenTelemetryLogBridge;
@@ -11,9 +14,6 @@ use std::error::Error;
1114
use std::fs::File;
1215
use std::os::unix::fs::MetadataExt;
1316
use std::time::Duration;
14-
use integration_test_runner::test_utils;
15-
use anyhow::Result;
16-
use ctor::dtor;
1717

1818
fn init_logs() -> Result<sdklogs::LoggerProvider> {
1919
let exporter_builder = LogExporter::builder();
@@ -40,7 +40,6 @@ fn init_logs() -> Result<sdklogs::LoggerProvider> {
4040

4141
#[tokio::test(flavor = "multi_thread", worker_threads = 4)]
4242
pub async fn test_logs() -> Result<()> {
43-
4443
// Make sure the container is running
4544
test_utils::start_collector_container().await;
4645

opentelemetry-otlp/tests/integration_test/tests/metrics.rs

Lines changed: 23 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,27 @@
11
#![cfg(unix)]
22

3-
use std::fs;
3+
use anyhow::{Context, Result};
4+
use ctor::dtor;
45
use integration_test_runner::metrics_asserter::{read_metrics_from_json, MetricsAsserter};
6+
use integration_test_runner::test_utils;
7+
use integration_test_runner::test_utils::start_collector_container;
58
use opentelemetry::KeyValue;
69
use opentelemetry_otlp::MetricExporter;
10+
use opentelemetry_proto::tonic::metrics::v1::MetricsData;
711
use opentelemetry_sdk::metrics::{MeterProviderBuilder, PeriodicReader, SdkMeterProvider};
812
use opentelemetry_sdk::Resource;
13+
use serde_json::Value;
14+
use std::fs;
915
use std::fs::File;
1016
use std::sync::Mutex;
1117
use std::time::Duration;
12-
use serde_json::Value;
13-
use anyhow::{Result, Context};
14-
use ctor::dtor;
15-
use integration_test_runner::test_utils;
16-
use integration_test_runner::test_utils::start_collector_container;
17-
use opentelemetry_proto::tonic::metrics::v1::MetricsData;
1818

1919
static SETUP_DONE: Mutex<bool> = Mutex::new(false);
2020

2121
static RESULT_PATH: &str = "actual/metrics.json";
2222

2323
/// Initializes the OpenTelemetry metrics pipeline
2424
async fn init_metrics() -> SdkMeterProvider {
25-
2625
let exporter_builder = MetricExporter::builder();
2726

2827
#[cfg(feature = "tonic-client")]
@@ -72,9 +71,15 @@ pub fn fetch_latest_metrics_for_scope(scope_name: &str) -> Result<Value> {
7271

7372
// Parse the JSON and filter metrics strictly by the scope name
7473
let mut filtered_json = json_line;
75-
if let Some(resource_metrics) = filtered_json.get_mut("resourceMetrics").and_then(|v| v.as_array_mut()) {
74+
if let Some(resource_metrics) = filtered_json
75+
.get_mut("resourceMetrics")
76+
.and_then(|v| v.as_array_mut())
77+
{
7678
resource_metrics.retain_mut(|resource| {
77-
if let Some(scope_metrics) = resource.get_mut("scopeMetrics").and_then(|v| v.as_array_mut()) {
79+
if let Some(scope_metrics) = resource
80+
.get_mut("scopeMetrics")
81+
.and_then(|v| v.as_array_mut())
82+
{
7883
// Retain only `ScopeMetrics` that match the specified scope_name
7984
scope_metrics.retain(|scope| {
8085
scope
@@ -98,11 +103,10 @@ pub fn fetch_latest_metrics_for_scope(scope_name: &str) -> Result<Value> {
98103
/// Performs setup for metrics tests, including environment setup and data seeding.
99104
/// This only needs to be done once for the whole test suite
100105
async fn setup_metrics_test() {
101-
102106
let mut done = SETUP_DONE.lock().unwrap();
103107
if !*done {
104108
println!("Running setup before any tests...");
105-
*done = true; // Mark setup as done
109+
*done = true; // Mark setup as done
106110

107111
// Make sure the collector container is running
108112
start_collector_container().await;
@@ -129,8 +133,10 @@ pub fn validate_metrics_against_results(scope_name: &str) -> Result<()> {
129133

130134
// Read the expected metrics from the results file
131135
let expected_metrics = {
132-
let file = File::open(&results_file_path)
133-
.context(format!("Failed to open results file: {}", results_file_path))?;
136+
let file = File::open(&results_file_path).context(format!(
137+
"Failed to open results file: {}",
138+
results_file_path
139+
))?;
134140
read_metrics_from_json(file)
135141
}?;
136142

@@ -171,8 +177,7 @@ mod tests {
171177
const METER_NAME: &str = "test_u64_counter_meter";
172178

173179
// Add data to u64_counter
174-
let meter = opentelemetry::global::meter_provider()
175-
.meter(METER_NAME);
180+
let meter = opentelemetry::global::meter_provider().meter(METER_NAME);
176181

177182
let counter = meter.u64_counter("counter_u64").build();
178183
counter.add(
@@ -191,15 +196,14 @@ mod tests {
191196
Ok(())
192197
}
193198

194-
195199
#[tokio::test(flavor = "multi_thread", worker_threads = 4)]
196200
// #[ignore] // skip when running unit test
197201
async fn test_histogram() -> Result<()> {
198202
_ = setup_metrics_test().await;
199203
const METER_NAME: &str = "test_histogram_meter";
200204

201205
// Add data to histogram
202-
let meter= opentelemetry::global::meter_provider().meter(METER_NAME);
206+
let meter = opentelemetry::global::meter_provider().meter(METER_NAME);
203207
let histogram = meter.u64_histogram("example_histogram").build();
204208
histogram.record(42, &[KeyValue::new("mykey3", "myvalue4")]);
205209
tokio::time::sleep(Duration::from_secs(5)).await;
@@ -216,7 +220,7 @@ mod tests {
216220
const METER_NAME: &str = "test_up_down_meter";
217221

218222
// Add data to up_down_counter
219-
let meter= opentelemetry::global::meter_provider().meter(METER_NAME);
223+
let meter = opentelemetry::global::meter_provider().meter(METER_NAME);
220224
let up_down_counter = meter.i64_up_down_counter("example_up_down_counter").build();
221225
up_down_counter.add(-1, &[KeyValue::new("mykey5", "myvalue5")]);
222226
tokio::time::sleep(Duration::from_secs(5)).await;

opentelemetry-otlp/tests/integration_test/tests/traces.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@ use opentelemetry::{
99
};
1010
use opentelemetry_otlp::SpanExporter;
1111

12+
use anyhow::Result;
13+
use ctor::dtor;
14+
use integration_test_runner::test_utils;
1215
use opentelemetry_proto::tonic::trace::v1::TracesData;
1316
use opentelemetry_sdk::{runtime, trace as sdktrace, Resource};
1417
use std::error::Error;
1518
use std::fs::File;
1619
use std::io::Write;
1720
use std::os::unix::fs::MetadataExt;
1821
use std::time::Duration;
19-
use anyhow::Result;
20-
use ctor::dtor;
2122
use tokio::time::sleep;
22-
use integration_test_runner::test_utils;
2323

2424
fn init_tracer_provider() -> Result<sdktrace::TracerProvider, TraceError> {
2525
let exporter_builder = SpanExporter::builder();
@@ -49,7 +49,6 @@ const ANOTHER_KEY: Key = Key::from_static_str("ex.com/another");
4949

5050
#[tokio::test(flavor = "multi_thread", worker_threads = 4)]
5151
pub async fn traces() -> Result<()> {
52-
5352
test_utils::start_collector_container().await;
5453

5554
let tracer_provider = init_tracer_provider().expect("Failed to initialize tracer provider.");

0 commit comments

Comments
 (0)