Skip to content

Consider making Configuration dict-like #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
toumorokoshi opened this issue Jun 3, 2020 · 3 comments
Closed

Consider making Configuration dict-like #771

toumorokoshi opened this issue Jun 3, 2020 · 3 comments
Labels
backlog discussion Issue or PR that needs/is extended discussion.

Comments

@toumorokoshi
Copy link
Member

#769 does a lot of work to make Configuration effectively a dictionary, under the hood.

Thoughts on making it a dict-like interface? I think it helps:

  1. expands the legal configuration values
  2. avoids typing complexity
  3. it's being used as a key-value set today, just generally with getters.

Thoughts?
@toumorokoshi toumorokoshi added the discussion Issue or PR that needs/is extended discussion. label Jun 3, 2020
@toumorokoshi
Copy link
Member Author

@ocelotl for your thoughts.

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan
chore: lint api package (open-telemetry#771)
218b290 
Co-Authored-By: Mark Wolff <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@codeboten
Copy link
Contributor

Configuration is no longer part of the api, when we tackle configuration in the future we can re-open if this still applies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @toumorokoshi