Indy module migration

[SylvainJuge]

The following instrumentation modules currently override the io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule#isIndyModule and return false.

Each of them will need to be modified in order to become "indy compliant".

This is part of #8999

• documentation: indy modules and migration process: indy advice docs & migration procedure #11546
• akka.akka-http-10.0 Akka server indy support #12243
• aws-sdk/aws-sdk-1.11 make aws-sdk indy compatible #11552
• elasticsearch/elasticsearch-api-client-7.16 make elasticsearch-* indy compatible #11554
• elasticsearch/elasticsearch-rest-7.0 make elasticsearch-* indy compatible #11554
• executors Executors indy support #11738
• finagglehttp make netty-* indy compatible #11559
• hibernate/hibernate-4.0 make hibernate-* indy compatible #11553
• hibernate/hibernate-6.0 make hibernate-* indy compatible #11553
• hibernate/hibernate-procedure-call-4.3 make hibernate-* indy compatible #11553
• influxdb Influxdb indy support #11710
• internal/internal-class-loader.javaagent-integration-tests.main
  • make internal-class-loader indy compatible #12195 (failed)
  • Make internal classloader instrumentation indy compatible #12242
• internal/internal-class-loader
  • make internal-class-loader indy compatible #12195 (failed)
  • Make internal classloader instrumentation indy compatible #12242
• internal/internal-reflection make internal-reflection indy compatible #12136
• jaxrs/jaxrs-2.0/jaxrs-2.0-jersey-2.0 make servlet3 + spring webmvc + jaxrs 2.0 indy compatible #12432
• kotlinx-coroutines/kotlinx-coroutines-1.0
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• netty.netty-4.1 make netty-* indy compatible #11559
• opentelemetry-api/opentelemetry-api-1.0
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.10
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.15
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.27
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.31
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.32
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.37
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-api/opentelemetry-api-1.4
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-extension-kotlin-1.0
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• opentelemetry-instrumentation-api
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• pekko/pekko-http-1.0 make Pekko instrumentation to indy compatible #12428
• ratpack/ratpack-1.4 make netty-* indy compatible #11559
• reactor/reactor-3.1
  Make OpenTelemetry-API Bridge and dependent instrumentations work with indy #11578
• rmi make rmi instrumentation indy-compatible + add module opener #12585
• servlet/servlet-3.0 make servlet3 + spring webmvc + jaxrs 2.0 indy compatible #12432
• spring/spring-webflux/spring-webflux-5.0 make netty-* indy compatible #11559
• spring/spring-webmvc/spring-webmvc-3.1 make servlet3 + spring webmvc + jaxrs 2.0 indy compatible #12432
• spring/spring-webmvc/spring-webmvc-6.0 make servlet3 + spring webmvc + jaxrs 2.0 indy compatible #12432
• internal/internal-lambda + leftovers indy instrumentation - leftovers migration #13074

The #9508 PR provides a list of reasons why those instrumentations need to be manually modified, for reference this #9508 PR is also the one that introduced a toggle to test this dispatch implementation through modification of advice classes.

The PRs that are tagged "test indy" (list) will run with this automatic migration to "indy dispatch".
The automatic transformation is provided by io.opentelemetry.javaagent.tooling.instrumentation.indy.AdviceTransformer ASM transformer.

---

Implementation proposal

This issue gather the steps to complete the 1st step of this "simple but tedious" plan:

1. migrate the instrumentation listed above
2. migrate all the instrumentations that are supported by AdviceTransformer
3. remove AdviceTransformer and cleanup

[SylvainJuge]

Because the migration will take a while, I have documented the migration and some of the characteristics of the non-inlined advices in #11546

The summary is:

• all instrumentation modules listed here are explicitly opting-out of automatic indy advice conversion
• those instrumentation modules need refactoring to become "indy compatible" with automatic advice conversion
• this issue tracks the global progress of this refactoring

Once everything has been migrated, this issue can be closed and we can start the next steps which might look like the following (to be further discussed):

• changing the default of otel.javaagent.experimental.indy configuration to true to perserve the ability to revert to inlining
• migrate all instrumentations to make them "indy native", mostly by adding inline = false
• implement further refactoring enabled by indy advices: remove shading, simplify helper classes, ...

[SylvainJuge]

After 8 months, we can finally consider this step as complete, so I'll close it 🎉.

The next steps are now described in #13031