-
Notifications
You must be signed in to change notification settings - Fork 83
Description
Note: yarn update:sdk-docs
doesn't update sdk-compatibility.json
any more due to a bug:
In process-sdk-readmes.ts
the nested lambda in markdownProcessor()
is supposed to carry out this update on its last invocation:
openfeature.dev/scripts/process-sdk-readmes.ts
Lines 167 to 170 in 5993d07
if (sdksProcessed >= sdks.length - 1) { | |
console.log('processed all sdks... writing matrix to file'); | |
sdkSupportMatrixGenerator.generateJson('src/datasets/sdks/sdk-compatibility.json'); | |
} |
However, it never takes place, because the assumption number of calls == sdks.length
is not true due to some SDKs (NextjsFlagsSDK
and SveltekitFlagsSDK
) not having a repo
attribute, and thus being removed from the processed files here:
.filter((sdk) => sdk.repo) |
openfeature.dev/src/datasets/sdks/nextjs-flags-sdk.ts
Lines 3 to 16 in 7eb7a9f
export const NextjsFlagsSDK: SDK = { | |
name: 'Vercel Flags', | |
description: 'Vercel Flags SDK with OpenFeature Adapter', | |
filename: 'javascript/nextjs-flags-sdk', | |
category: 'Client', | |
slug: 'nextjs-flags-sdk', | |
branch: 'main', | |
logoKey: 'flags-sdk-no-fill.svg', | |
technology: 'Next.js', | |
parentTechnology: 'JavaScript', | |
skipParentTechnologyProviders: true, | |
href: 'https://flags-sdk.dev/docs/api-reference/adapters/openfeature', | |
includeInSupportMatrix: false, | |
}; |
openfeature.dev/src/datasets/sdks/sveltekit-flags-sdk.ts
Lines 3 to 16 in 7eb7a9f
export const SveltekitFlagsSDK: SDK = { | |
name: 'Vercel Flags', | |
description: 'Vercel Flags SDK with OpenFeature Adapter', | |
filename: 'javascript/sveltekit-flags-sdk', | |
category: 'Client', | |
slug: 'sveltekit-flags-sdk', | |
branch: 'main', | |
logoKey: 'flags-sdk-no-fill.svg', | |
technology: 'SvelteKit', | |
parentTechnology: 'JavaScript', | |
skipParentTechnologyProviders: true, | |
href: 'https://flags-sdk.dev/docs/api-reference/adapters/openfeature', | |
includeInSupportMatrix: false, | |
}; |
So the two mentioned SDK objects should either receive a repo
attribute, or the first referenced code block needs to be refactored.
Originally posted by @bencehornak in #1256 (comment)