Skip to content

Commit 1c5db1d

Browse files
committed
remove failing test to test vmlens integration
Signed-off-by: christian.lutnik <[email protected]>
1 parent d0b51d4 commit 1c5db1d

File tree

2 files changed

+1
-26
lines changed

2 files changed

+1
-26
lines changed

.github/workflows/pullrequest.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,7 @@ jobs:
4141
restore-keys: |
4242
${{ runner.os }}${{ matrix.build.java }}-maven-
4343
44-
- if: matrix.build.java == '17'
45-
name: Verify
46-
run: mvn --batch-mode --update-snapshots --activate-profiles e2e,${{ matrix.build.profile }} verify
47-
48-
- if: matrix.build.java != '17'
49-
name: Verify
44+
- name: Verify with Maven
5045
run: mvn --batch-mode --update-snapshots --activate-profiles e2e,${{ matrix.build.profile }} verify
5146

5247
- if: matrix.build.java == '17'

src/test/java/dev/openfeature/sdk/vmlens/VmLensTest.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,6 @@
2626
class VmLensTest {
2727
final OpenFeatureAPI api = OpenFeatureAPITestUtil.createAPI();
2828

29-
// todo add tests:
30-
// concurrent changing of context thorugh client.setctx... and flags with a targeting rule depending on that context
31-
// concurrent setting of context thorugh client.setctx... and flags with a targeting rule depending on that context
32-
// concurrent changing of context through a hook and flags with a targeting rule depending on that context
33-
// concurrent setting of context through a hook and flags with a targeting rule depending on that context
34-
3529
@BeforeEach
3630
void setUp() {
3731
var flags = new HashMap<String, Flag<?>>();
@@ -92,18 +86,4 @@ void concurrentContextSetting() {
9286
}
9387
}
9488
}
95-
96-
@Test
97-
void fails() {
98-
int[] i = new int[] {0};
99-
try (AllInterleavings allInterleavings = new AllInterleavings("pls fail!")) {
100-
while (allInterleavings.hasNext()) {
101-
Runner.runParallel(
102-
() -> i[0]++,
103-
() -> i[0]++
104-
);
105-
assertTrue(i[0] > 0);
106-
}
107-
}
108-
}
10989
}

0 commit comments

Comments
 (0)