Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django caching for explore pages #75

Closed
duncandewhurst opened this issue Oct 7, 2020 · 5 comments
Closed

Use Django caching for explore pages #75

duncandewhurst opened this issue Oct 7, 2020 · 5 comments

Comments

@duncandewhurst
Copy link
Contributor

duncandewhurst commented Oct 7, 2020

See open-contracting/cove-ocds#90

@jpmckinney requested that this is done as part of the OC4IDS sprint

michaelwood added a commit that referenced this issue Oct 7, 2020
Add with defaults as suggested in Django documentation.

Fixes: #75
michaelwood added a commit that referenced this issue Oct 12, 2020
- If not in DEBUG mode enable memcached backend using defaults as suggested
in Django documentation.
- Updated README to include note about cache
- Added dependency on python-memcached and updated requirements

Fixes: #75
@jpmckinney
Copy link
Member

@michaelwood Should we update the deploy repo to install memcached before closing this issue?

@jpmckinney jpmckinney reopened this Oct 13, 2020
@michaelwood
Copy link
Contributor

@michaelwood Should we update the deploy repo to install memcached before closing this issue?

Yes we can do. I wasn't sure if you were going to get the server management folks to do this.

Would you like us to separate out cove-oc4ids into it's own entry in the salt top file or keep the existing config with cove-live* https://github.com/open-contracting/deploy/blob/4daad97231534ebfccebb2c6852a251591cc9157/salt/top.sls#L45 (which would on next deploy also deploy a redundant memcached server to the cove-ocds). Another option might be to use a flag set in the pillar to make it conditional in the cove.sls but that wouldn't be very neat. After deciding this we will create a /salt/memcached.sls file to be referenced in the top.sls.

@jpmckinney
Copy link
Member

jpmckinney commented Oct 14, 2020

I think we can just edit cove.sls since the intention is for cove-ocds to also use memcached, so it's okay to have an unused memcached server until that happens. (I'm assuming this is just installing the package, but if Memcached is more involved than that, then it can have its own SLS file.)

@michaelwood
Copy link
Contributor

Grand, I don't have the required access to push a branch to the deploy repo, this is the patch I'm planning on sending:

diff --git a/salt/cove.sls b/salt/cove.sls
index aac1f26..c3416b7 100644
--- a/salt/cove.sls
+++ b/salt/cove.sls
@@ -28,3 +28,8 @@ MAILTO:
     - name: MAILTO
     - value: [email protected],[email protected]
     - user: cove
+
+memcached_server:
+  pkg.installed:
+    - pkgs:
+     - memcached

Could you grant me access?

@jpmckinney
Copy link
Member

@michaelwood I've invited you to the Servers team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants