Skip to content

Commit 92eed8c

Browse files
authored
bump pybind11_json to 0.2.15 and remove one test skip given a segfault was fixed. closes #319 (#389)
1 parent bd3e22c commit 92eed8c

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

tests/test_aero_mode.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,16 +291,21 @@ def test_ctor_fails_with_nonunique_mass_fracs():
291291
assert str(exc_info.value) == "mass_frac keys must be unique"
292292

293293
@staticmethod
294-
def test_segfault_case(): # TODO #319
295-
pytest.skip()
296-
294+
@pytest.mark.skipif(platform.machine() == "arm64", reason="TODO #348")
295+
def test_fixed_segfault_case_on_circular_reference():
296+
# arrange
297297
aero_data = ppmc.AeroData(AERO_DATA_CTOR_ARG_MINIMAL)
298298
fishy_ctor_arg = copy.deepcopy(AERO_MODE_CTOR_LOG_NORMAL)
299299
fishy_ctor_arg["test_mode"]["mass_frac"].append(
300300
fishy_ctor_arg["test_mode"]["mass_frac"]
301301
)
302-
print(fishy_ctor_arg)
303-
ppmc.AeroMode(aero_data, fishy_ctor_arg)
302+
303+
# act
304+
with pytest.raises(TypeError) as exc_info:
305+
ppmc.AeroMode(aero_data, fishy_ctor_arg)
306+
307+
# assert
308+
assert "incompatible constructor arguments" in str(exc_info.value)
304309

305310
@staticmethod
306311
@pytest.mark.skipif(platform.machine() == "arm64", reason="TODO #348")

0 commit comments

Comments
 (0)