Merge pull request #107 from opal/staging

18th Staging

Author: hmdne

CHANGELOG.md

@@ -1,4 +1,7 @@
 ## 0.3.4
+* Element#children=
+* Support more methods on Media
+* Event::Custom to support non-enumerable properties
 * DOM::Element::Form: #valid?, #request_submit, #ajax_submit
 * Compatibility for Opal-RSpec 1.0
 

opal/browser/dom/element.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 # Requires are moved to the bottom of this file.
 
 module Browser; module DOM
@@ -367,6 +369,8 @@ def inner_dom=(node)
     self << node
   end
 
+  alias children= inner_dom=
+
   # @!attribute inner_html
   # @return [String] the inner HTML of the element
   def inner_html

opal/browser/dom/element/attributes.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Attributes

opal/browser/dom/element/button.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Button < Element

opal/browser/dom/element/custom.rb

@@ -1,5 +1,6 @@
 # use_strict: true
 # helpers: truthy
+# backtick_javascript: true
 
 module Browser; module DOM; class Element < Node
 
@@ -174,4 +175,4 @@ def detached_once
   include Mixin
 end
 
-end; end; end
+end; end; end

opal/browser/dom/element/data.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Data

opal/browser/dom/element/editable.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM
 
 class Element < Node

opal/browser/dom/element/form.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Form < Element

opal/browser/dom/element/iframe.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Iframe < Element

opal/browser/dom/element/image.rb

@@ -1,23 +1,14 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Image < Element
   def_selector "img"
 
-  def complete?
-    `#@native.complete`
-  end
-
-  def cross?
-    `#@native.crossOrigin`
-  end
-
-  def height
-    `#@native.naturalHeight`
-  end
-
-  def width
-    `#@native.naturalWidth`
-  end
+  alias_native :complete?, :complete
+  alias_native :cross?, :crossOrigin
+  alias_native :height, :naturalHeight
+  alias_native :width, :naturalWidth
 end
 
 Img = Image

opal/browser/dom/element/input.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Input < Element
@@ -14,21 +16,11 @@ def value
     }
   end
 
-  def value=(value)
-    `#@native.value = #{value}`
-  end
-
-  def name_
-    `#@native.name`
-  end
-
-  def type
-    `#@native.type`
-  end
-
-  def checked?
-    `#@native.checked`
-  end
+  alias_native :value=
+  alias_native :name_, :name
+  alias_native :type
+  alias_native :checked?, :checked
+  alias_native :enabled?, :enabled
 
   def check!
     `#@native.checked = 'checked'`
@@ -38,10 +30,6 @@ def uncheck!
     `#@native.checked = ''`
   end
 
-  def enabled?
-    `#@native.enabled`
-  end
-
   def disable!
     `#@native.disabled = 'disabled'`
   end

opal/browser/dom/element/media.rb

@@ -1,9 +1,10 @@
 module Browser; module DOM; class Element < Node
 
 class Media < Element
-  def play
-    `#@native.play()`
-  end
+  alias_native :play
+  alias_native :pause
+  alias_native :time, :currentTime
+  alias_native :time=, :currentTime
 end
 
 class Video < Media

opal/browser/dom/element/offset.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Offset

opal/browser/dom/element/scroll.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 # @todo Consider using the new interfaces which allow for optional

opal/browser/dom/element/select.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Select < Element
@@ -14,9 +16,7 @@ def value
     }
   end
 
-  def value= value
-    `#@native.value = #{value.to_n}`
-  end
+  alias_native :value=
 
   def labels
     NodeSet[Native::Array.new(`#@native.labels`)]
@@ -30,10 +30,7 @@ def option
     DOM(`#@native.options[#@native.selectedIndex]`)
   end
 
-  def index
-    `#@native.selectedIndex`
-  end
-
+  alias_native :index, :selectedIndex
   alias_native :multiple?, :multiple
   alias_native :required?, :required
   alias_native :length

opal/browser/dom/element/size.rb

@@ -1,6 +1,8 @@
 module Browser; module DOM; class Element < Node
 
 class Size
+  include Native::Wrapper
+
   attr_reader :element
 
   # @private
@@ -12,35 +14,27 @@ def initialize(element, *inc)
 
   # @!attribute width
   # @return [Integer] the element width
-  def width
-    `#@native.offsetWidth`
-  end
+  alias_native :width, :offsetWidth
 
   def width=(value)
     @element.style[:width] = value
   end
 
   # @!attribute height
   # @return [Integer] the element height
-  def height
-    `#@native.offsetHeight`
-  end
+  alias_native :height, :offsetHeight
 
   def height=(value)
     @element.style[:height] = value
   end
 
   # @!attribute client_width
   # @return [Integer] the content-box width of an element
-  def client_width
-    `#@native.clientWidth`
-  end
+  alias_native :client_width, :clientWidth
 
   # @!attribute client_height
   # @return [Integer] the content-box height of an element
-  def client_height
-    `#@native.clientHeight`
-  end
+  alias_native :client_height, :clientHeight
 end
 
 end; end; end

opal/browser/dom/element/template.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Template < Element

opal/browser/dom/element/textarea.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; module DOM; class Element < Node
 
 class Textarea < Element
@@ -14,9 +16,7 @@ def value
     }
   end
 
-  def value=(value)
-    `#@native.value = #{value}`
-  end
+  alias_native :value=
 
   def clear
     `#@native.value = ''`

opal/browser/event/animation.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; class Event
 
 class Animation < Event
@@ -8,13 +10,9 @@ def self.supported?
   end
 
   class Definition < Definition
-    def animation=(value)
-      `#@native.animationName = #{value}`
-    end
-
-    def elapsed=(value)
-      `#@native.elapsedTime = #{value}`
-    end
+    alias_native :name=, :animationName=
+    alias_native :animation=, :animationName=
+    alias_native :elapsed=, :elapsedTime=
   end
 
   if Browser.supports? 'Event.constructor'

opal/browser/event/audio_processing.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; class Event
 
 class AudioProcessing < Event
@@ -8,17 +10,9 @@ def self.supported?
   end
 
   class Definition < Definition
-    def time=(value)
-      `#@native.playbackTime = #{value}`
-    end
-
-    def input=(value)
-      `#@native.inputBuffer = #{value}`
-    end
-
-    def output=(value)
-      `#@native.outputBuffer = #{value}`
-    end
+    alias_native :time=, :playbackTime=
+    alias_native :input=, :inputBuffer=
+    alias_native :output=, :outputBuffer=
   end
 
   if Browser.supports? 'Event.constructor'

opal/browser/event/base.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser
 
 class Event
@@ -16,14 +18,10 @@ def self.new(&block)
     end
 
     # Set the event as bubbling.
-    def bubbles=(value)
-      `#@native.bubbles = #{value}`
-    end
+    alias_native :bubbles=
 
     # Set the event as cancelable.
-    def cancelable=(value)
-      `#@native.cancelable = #{value}`
-    end
+    alias_native :cancelable=
   end
 
   module Target

opal/browser/event/before_unload.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; class Event
 
 class BeforeUnload < Event

opal/browser/event/clipboard.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; class Event
 
 class Clipboard < Event
@@ -8,13 +10,8 @@ def self.supported?
   end
 
   class Definition < Definition
-    def data=(value)
-      `#@native.data = #{value}`
-    end
-
-    def type=(value)
-      `#@native.dataType = #{value}`
-    end
+    alias_native :data=
+    alias_native :type=, :dataType=
   end
 
   if Browser.supports? 'Event.constructor'

opal/browser/event/close.rb

@@ -1,3 +1,5 @@
+# backtick_javascript: true
+
 module Browser; class Event
 
 class Close < Event
@@ -8,13 +10,8 @@ def self.supported?
   end
 
   class Definition < Definition
-    def code=(value)
-      `#@native.code = #{value}`
-    end
-
-    def reason=(value)
-      `#@native.reason = #{value}`
-    end
+    alias_native :code=
+    alias_native :reason=
 
     def clean!(value)
       `#@native.wasClean = true`