Use the same password for both dev and prod /metrics #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @LDiazN |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Tue, 25 Feb 2025 11:36:22 GMT |
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @LDiazN |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Tue, 25 Feb 2025 11:38:28 GMT |
hellais
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the dev environment configuration to use the same password for /metrics in both prod and dev for ECS tasks
In order to do this we also changed the way the credentials are stored to use
aws_ssmparameters instead ofsecrets_manager(also related to #114)Since this change was breaking the monitoring for several systems in prod that were using the old password, I used the old secrets manager password value for the new ssm manager password, meaning that a change in the secrets manager password can lead to breaking monitoring for some systems.
For this reason, we should add a follow up issue to migrate all
prometheus_metrics_passwordoccurrences to use ssm and run that migration carefully to avoid disruptions in productionThis PR solves #187