Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe it is time to rename the Chat Template? #6693

Open
FartyPants opened this issue Jan 23, 2025 · 0 comments
Open

Maybe it is time to rename the Chat Template? #6693

FartyPants opened this issue Jan 23, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@FartyPants
Copy link
Contributor

FartyPants commented Jan 23, 2025

I'm writing a book about my notes for training LORA and QLORA and preparing datasets for different scenarios with WebUI at the center and boy this part is CONFUSING to describe in relation to everybody else.

It's confusing, because everyone else calls the WebUI "Instruct" template "Chat Template" so I bet more than one person is confused what Chat / Instruct means.

I suggest renaming the "Chat Template" and anything related to it as RP or Role Play, because THAT'S WHAT IT IS and basically abandon the Instruction word and call it Chat Template, because THAT'S WHAT IT IS.

It's now commonly used that the role based template user/assistant is Chat Template and what you do with them is "Chat"
https://huggingface.co/docs/transformers/en/chat_templating

So in JINJA Parameters screen we will have Chat Template on left and RP Template on right

Image

On the Chat Window we will have 3 modes

[RP], [RP-Chat] and [Chat (instruct)]

We might call the Chat (instruct), just for now until everyone gets used to it.

I feel this will be far LESS confusing. I get it why it is like that, but Chat is no longer what everyone think of Chat. Let's call spade spade, it is Role Play.

What do you think?

@FartyPants FartyPants added the enhancement New feature or request label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant