remove unused collections operations

Author: zhangchiqing

storage/operation/collections.go

@@ -26,17 +26,6 @@ func RemoveCollection(w storage.Writer, collID flow.Identifier) error {
 	return RemoveByKey(w, MakePrefix(codeCollection, collID))
 }
 
-// IndexCollectionPayload will overwrite any existing index, which is acceptable
-// because the blockID is derived from txIDs within the payload, ensuring its uniqueness.
-func IndexCollectionPayload(w storage.Writer, blockID flow.Identifier, txIDs []flow.Identifier) error {
-	return UpsertByKey(w, MakePrefix(codeIndexCollection, blockID), txIDs)
-}
-
-// LookupCollection looks up the collection for a given cluster payload.
-func LookupCollectionPayload(r storage.Reader, blockID flow.Identifier, txIDs *[]flow.Identifier) error {
-	return RetrieveByKey(r, MakePrefix(codeIndexCollection, blockID), txIDs)
-}
-
 // UnsafeIndexCollectionByTransaction inserts a collection id keyed by a transaction id
 // Unsafe because a transaction can belong to multiple collections, indexing collection by a transaction
 // will overwrite the previous collection id that was indexed by the same transaction id
@@ -54,12 +43,6 @@ func LookupCollectionByTransaction(r storage.Reader, txID flow.Identifier, colle
 	return RetrieveByKey(r, MakePrefix(codeIndexCollectionByTransaction, txID), collectionID)
 }
 
-// RemoveCollectionPayloadIndices removes a collection id indexed by a block id
-// any error returned are exceptions
-func RemoveCollectionPayloadIndices(w storage.Writer, blockID flow.Identifier) error {
-	return RemoveByKey(w, MakePrefix(codeIndexCollection, blockID))
-}
-
 // RemoveCollectionByTransactionIndex removes a collection id indexed by a transaction id,
 // created by [UnsafeIndexCollectionByTransaction].
 // Any error returned is an exception.

storage/operation/collections_test.go

@@ -54,40 +54,5 @@ func TestCollections(t *testing.T) {
 			})
 			require.NoError(t, err)
 		})
-
-		t.Run("Index and lookup", func(t *testing.T) {
-			expected := unittest.CollectionFixture(1).Light()
-			blockID := unittest.IdentifierFixture()
-
-			_ = db.WithReaderBatchWriter(func(rw storage.ReaderBatchWriter) error {
-				err := operation.UpsertCollection(rw.Writer(), &expected)
-				assert.NoError(t, err)
-				err = operation.IndexCollectionPayload(rw.Writer(), blockID, expected.Transactions)
-				assert.NoError(t, err)
-				return nil
-			})
-
-			var actual flow.LightCollection
-			err := operation.LookupCollectionPayload(db.Reader(), blockID, &actual.Transactions)
-			assert.NoError(t, err)
-			assert.Equal(t, expected, actual)
-		})
-
-		t.Run("Index and lookup by transaction ID", func(t *testing.T) {
-			expected := unittest.IdentifierFixture()
-			transactionID := unittest.IdentifierFixture()
-			actual := flow.Identifier{}
-
-			_ = db.WithReaderBatchWriter(func(rw storage.ReaderBatchWriter) error {
-				err := operation.UnsafeIndexCollectionByTransaction(rw.Writer(), transactionID, expected)
-				assert.NoError(t, err)
-				return nil
-			})
-
-			err := operation.LookupCollectionByTransaction(db.Reader(), transactionID, &actual)
-			assert.NoError(t, err)
-
-			assert.Equal(t, expected, actual)
-		})
 	})
 }