Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Zen Browser #371

Closed
black-ish opened this issue Dec 21, 2024 · 21 comments
Closed

Not compatible with Zen Browser #371

black-ish opened this issue Dec 21, 2024 · 21 comments

Comments

@black-ish
Copy link

black-ish commented Dec 21, 2024

It seems TMP is not compatible with Zen Browser

2024 12 17_22:38:09_PuErisSJpG

From what I could copy from the console:

1734471336515	addons.xpi	WARN	Checking D:\Zen\distribution\extensions for addons
Attempt to override an existing message: "appmenu-edit-profile". preview/profiles.ftl
Attempt to override an existing message: "appmenu-profiles". preview/profiles.ftl
Shortcuts applied... ZenKeyboardShortcuts.mjs:944:15
Attempt to override an existing message: "tab-context-unnamed-group". preview/tabGroups.ftl
Attempt to override an existing message: "tab-context-move-tab-to-new-group". preview/tabGroups.ftl
Attempt to override an existing message: "tab-context-move-tab-to-group". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-new-window". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-save". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-ungroup". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-delete". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-done". preview/tabGroups.ftl
Attempt to override an existing message: "tab-context-ungroup-tab". preview/tabGroups.ftl
Attempt to override an existing message: "appmenu-other-profiles". preview/profiles.ftl
Attempt to override an existing message: "appmenu-manage-profiles". preview/profiles.ftl
Attempt to override an existing message: "appmenu-create-profile". preview/profiles.ftl
Attempt to override an existing message: "appmenu-edit-profile". preview/profiles.ftl
Attempt to override an existing message: "appmenu-profiles". preview/profiles.ftl
HTTPS-Only Mode: Not upgrading insecure request “http://o.pki.goog/wr2” because it is exempt.
4
Zen CKS: Initialized ZenKeyboardShortcuts.mjs:854:15
HTTPS-Only Mode: Not upgrading insecure request “http://o.pki.goog/wr2” because it is exempt.

No chrome package registered for chrome://tabmix-version/skin/win/browser.css
NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIDOMWindowUtils.loadSheetUsingURIString] ScriptsLoader.jsm:102


    Welcome to Zen Browser!

  If you are seeing this message, it means that you have successfully opened Zen's developer console.
  Here you can see all the logs and errors that Zen is generating.

  If you have any questions or need help, please contact us in any media in https://zen-browser.app/

  Note: This developer console is not the same as the browser console, it has access to Zen's internal functions and variables, including your passwords and other sensitive information. Please do not paste any code here unless you know what you are doing.

  ZenStartup.mjs:109:15
HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/canonical.html” because it is exempt.

ZenThemeModifier: init browser layout ZenStartup.mjs:18:17
ZenWorkspacesStorage: Initializing... ZenWorkspacesStorage.mjs:3:13
1734471337821	addons.xpi	WARN	Can't get modified time of D:\Zen\browser\features\[email protected]
HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/canonical.html” because it is exempt.

HTTPS-Only Mode: Not upgrading insecure request “http://o.pki.goog/wr2” because it is exempt.
4
Applying chrome://tabmixplus/content/tabmix.xhtml to chrome://browser/content/browser.xhtml Overlays.jsm:93:15
HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/canonical.html” because it is exempt.

[ZenThemesImporter]: No enabled Zen themes. ZenThemesImporter.mjs:187:13
HTTPS-Only Mode: Not upgrading insecure request “http://o.pki.goog/wr2” because it is exempt.

[ZenThemesImporter]: Sheet successfully registered ZenThemesImporter.mjs:132:15
HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/canonical.html” because it is exempt.

HTTPS-Only Mode: Not upgrading insecure request “http://o.pki.goog/wr2” because it is exempt.

Applying chrome://tabmixplus/content/overlay/tabContextMenu.xhtml to chrome://browser/content/browser.xhtml Overlays.jsm:93:15
Loading eval'd script into chrome://browser/content/browser.xhtml Overlays.jsm:564:15
ReferenceError: Tabmix is not defined
    <anonymous> data:application/javascript,%0A%20%20%20%20%2F%2F%20with%20bootstrap.js%20we%20get%20here%20after%20DOMContentLoaded%20was%20fired%0A%20%20%20%20%2F%2F%20we%20can%20call%20our%20initializer%20with%20'onContentLoaded'%20flag%0A%20%20%20%20Tabmix.initialization.init.initialized%20%3D%20false%3B%0A%20%20%20%20TMP_eventListener.init()%3B%0A%20%20%20%20Tabmix.initialization.run(%22onContentLoaded%22%2C%20gBrowser.tabContainer)%3B%0A%20%20:4
    loadScript chrome://tabmix-resource/content/bootstrap/Overlays.jsm:570
    load chrome://tabmix-resource/content/bootstrap/Overlays.jsm:172
Overlays.jsm:572:17
Key key_tm_mergeWin of menuitem Merge Windows could not be found menu.js:295:21
Key key_tm_sm_saveone of menuitem Save This Window… could not be found menu.js:295:21
Key key_tm_sm_saveone of menuitem Save All Windows… could not be found menu.js:295:21
Key key_tm_dupTab of menuitem Duplicate Tab could not be found menu.js:295:21
Key key_tm_detachTab of menuitem Move to New Window could not be found menu.js:295:21
Key key_tm_mergeWin of menuitem Merge Windows could not be found menu.js:295:21
Key key_undoCloseTab of menuitem null could not be found menu.js:295:21
HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/canonical.html” because it is exempt.
2
TypeError: NetworkError: Network request failed
    onerror resource://services-settings/Utils.sys.mjs:238
RemoteSettingsClient.sys.mjs:536:15
TypeError: NetworkError: Network request failed
    onerror resource://services-settings/Utils.sys.mjs:238
IgnoreLists.sys.mjs:87:15
ZenPinnedTabsStorage: Initializing... ZenPinnedTabsStorage.mjs:3:13
HTTPS-Only Mode: Not upgrading insecure request “http://r10.o.lencr.org/” because it is exempt.

ZenWorkspaces: ZenWorkspaces initialized ZenWorkspaces.mjs:76:13
Applying chrome://tabmixplus/content/preferences/overlay/aboutaddons.xhtml to about:addons Overlays.jsm:93:15
Loading script chrome://tabmixplus/content/preferences/overlay/aboutaddons.js into about:addons Overlays.jsm:557:15
TypeError: NetworkError: Network request failed
    onerror resource://services-settings/Utils.sys.mjs:238
RemoteSettingsClient.sys.mjs:536:15
TypeError: NetworkError: Network request failed
    onerror resource://services-settings/Utils.sys.mjs:238
RemoteSettingsClient.sys.mjs:536:15
TypeError: NetworkError: Network request failed
    onerror resource://services-settings/Utils.sys.mjs:238
RemoteSettingsClient.sys.mjs:536:15
HTTPS-Only Mode: Not upgrading insecure request “http://r10.o.lencr.org/” because it is exempt.

HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/success.txt?ipv4” because it is exempt.

HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/success.txt?ipv6” because it is exempt.

Uncaught TypeError: windowRoot.ownerGlobal.Tabmix is undefined
    updateShowItemPreferences chrome://tabmixplus/content/preferences/overlay/aboutaddons.js:25
3 aboutaddons.js:25:11
Attempt to override an existing message: "cfr-protections-panel-header". browser/protectionsPanel.ftl
Attempt to override an existing message: "cfr-protections-panel-body". browser/protectionsPanel.ftl
Attempt to override an existing message: "cfr-protections-panel-link-text". browser/protectionsPanel.ftl
Attempt to override an existing message: "tab-context-unnamed-group". preview/tabGroups.ftl
Attempt to override an existing message: "tab-context-move-tab-to-new-group". preview/tabGroups.ftl
Attempt to override an existing message: "tab-context-move-tab-to-group". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-new-window". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-save". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-ungroup". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-action-delete". preview/tabGroups.ftl
Attempt to override an existing message: "tab-group-editor-done". preview/tabGroups.ftl
Attempt to override an existing message: "tab-context-ungroup-tab". preview/tabGroups.ftl
Attempt to override an existing message: "appmenu-other-profiles". preview/profiles.ftl
Attempt to override an existing message: "appmenu-manage-profiles". preview/profiles.ftl
Attempt to override an existing message: "appmenu-create-profile". preview/profiles.ftl
Attempt to override an existing message: "appmenu-edit-profile". preview/profiles.ftl
Attempt to override an existing message: "appmenu-profiles". preview/profiles.ftl
Key event not available on some keyboard layouts: key=“u” modifiers=“alt,accel” id=“zen-split-view-unsplit” browser.xhtml
Key event not available on some keyboard layouts: key=“h” modifiers=“alt,accel” id=“zen-split-view-horizontal” browser.xhtml
Key event not available on some keyboard layouts: key=“v” modifiers=“alt,accel” id=“zen-split-view-vertical” browser.xhtml
Key event not available on some keyboard layouts: key=“g” modifiers=“alt,accel” id=“zen-split-view-grid” browser.xhtml
Key event not available on some keyboard layouts: key=“q” modifiers=“alt,accel” id=“zen-workspace-backward” browser.xhtml
Key event not available on some keyboard layouts: key=“e” modifiers=“alt,accel” id=“zen-workspace-forward” browser.xhtml
Key event not available on some keyboard layouts: key=“t” modifiers=“alt,accel” id=“zen-compact-mode-show-toolbar” browser.xhtml
Key event not available on some keyboard layouts: key=“s” modifiers=“alt,accel” id=“zen-compact-mode-show-sidebar” browser.xhtml
Key event not available on some keyboard layouts: key=“c” modifiers=“alt,accel” id=“zen-compact-mode-toggle” browser.xhtml
Key event not available on some keyboard layouts: key=“i” modifiers=“accel,alt,shift” id=“key_browserToolbox” browser.xhtml
HTTPS-Only Mode: Not upgrading insecure request “http://o.pki.goog/s/wr3/CSo” because it is exempt.

TypeError: NetworkError: Network request failed
    onerror resource://services-settings/Utils.sys.mjs:238
RemoteSettingsClient.sys.mjs:536:15
HTTPS-Only Mode: Not upgrading insecure request “http://detectportal.firefox.com/canonical.html” because it is exempt.

In theory it should be compatible, considering it's a Firefox fork. And most functions should work right?
I'm no coder so I can't help much except test whatever is asked if there is any interest to make it compatible.

I'm familiar with the installation process of TMP and installed it succesfully on many Firefox based browsers so I'm sure I did it right.

Can it be made to be compatible with Zen?

@pyrates999
Copy link

is this the zen browser you installed? https://github.com/zen-browser/desktop

@black-ish
Copy link
Author

Yes.

@pyrates999
Copy link

Check that you followed the instructions here first: https://onemen.github.io/tabmixplus-docs/other/installation/

@black-ish
Copy link
Author

Please read my post fully, I installed TMP successfully on multiple Firefox-based browsers without issue, like Floorp, Mercury, Waterfox, Firefox. Only Zen makes some trouble.
Which is why I tried all available troubleshooting steps that are available, and since it still doesn't work I opened this issue.
It tried all possible things before I opened this issue.

@pyrates999
Copy link

Still good to verify that you followed the steps correctly considering this is a fork of firefox. I've had to do that on here before.

@black-ish
Copy link
Author

Of course.
When it wasn't working the first time I checked that I followed the steps and didn't miss anthing.
Then I made a new installation from scratch where I followed it directly from the site and not from memory.
All to no avail though.

@onemen
Copy link
Owner

onemen commented Dec 22, 2024

  • The extensions startup fails to load the file chrome://tabmix-os/skin/browser.css
    I need to investigate more to find the reason for this fail.

  • Zen browser is using different version numbers then Firefox, i need to find a way to match Zen version "1.0.2-b.3" with its compatible Firefox version.

I will appreciate any one who would like to help make Tab Mix Plus compatible with Zen Browser.

@black-ish
Copy link
Author

black-ish commented Dec 22, 2024

Thank you for responding 👍
I doubt I will be helpfull as I'm no coder.
But whatever else you might need I'll try.

@onemen
Copy link
Owner

onemen commented Dec 30, 2024

@black-ish

This test build should fix this issue

Download this test build for Zen

Rename it to .xpiand install it.

Report back

@black-ish
Copy link
Author

Thank you!
Yea seems to work, it installs properly and the incompatibility warning is gone.
I can open the settings and apply them.
Changes take effect.
If I see anything that's amiss I will report back in the next few days.

@onemen onemen closed this as completed in 382260e Jan 14, 2025
@onemen
Copy link
Owner

onemen commented Jan 14, 2025

Use latest dev-build

@black-ish
Copy link
Author

Took me a while, life got in the way:
Things that don't work:

  • Show Tab close button on all tabs
  • Setting Tab Width and it's sub-settings (Probably because of vertical tabs)
  • Mouse Gestures - When closing a tab, other tabs should not resize until cursor leaves toolbar region (Probably because of vertical rabs)
  • Mouse Gestures - When scrolling over the tba-bar (Probably because of vertical rabs)

Those are the only things I found to not work.
The "Show Tab close button on all tabs" is the only thing I can not really attribute to the vertical tabs.

I tested probably 98% of the rest but I'm sure I missed something, but it works fine for all my use cases.

@onemen
Copy link
Owner

onemen commented Jan 25, 2025

Is there any preference in Zen to turn of vertical tabs mode?

@onemen onemen reopened this Jan 25, 2025
@black-ish
Copy link
Author

Yes there is an about:config setting that can switch, but it's not supported. they may support it in the future.
The relevant issue are here and here.

@llbbl
Copy link

llbbl commented Feb 3, 2025

will this be pushed to the firefox extensions?

@onemen
Copy link
Owner

onemen commented Feb 3, 2025

will this be pushed to the firefox extensions?

I you refers to about:config preferences specific to Zen, the answer is no.

Setting Tab Width and it's sub-settings (Probably because of vertical tabs) Mouse Gestures - When closing a tab, other tabs should not resize until cursor leaves toolbar region (Probably because of vertical rabs) Mouse Gestures - When scrolling over the tba-bar (Probably because of vertical rabs)
These features are disable when you are in vertical mode.

The fix to this issue is already included in development build.
You can Download and install it today.

It will be in the next version

@onemen
Copy link
Owner

onemen commented Feb 5, 2025

Latest dev-build fixed Show Tab close button on all tabs issue.

@black-ish
Copy link
Author

black-ish commented Feb 5, 2025

Thank you :)
Just checked it out, it works.
There is a bug though:
While having the setting "Close tab button" active, on the next opening of the TMP Options window the "Place on the left side" option is greyed out and can't be set, disabling the "Close tab button" option and re-enabling it again fixes it as long as the TMP Options window is open.

And the option "Place on the left side" doesn't work.

@onemen
Copy link
Owner

onemen commented Feb 5, 2025

I change to make it always disabled in vertical tabs

@onemen
Copy link
Owner

onemen commented Feb 12, 2025

I am closing this now.

for new bugs open new issue

@pyrates999
Copy link

I am closing this now.

for new bugs open new issue

You forgot to close this ;)

@onemen onemen closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants