Fix Warnings #28
Comments
|
@derpeter could you please take a look at this as well? |
PeterHasse
added a commit
that referenced
this issue
Jul 17, 2024
the rest needs more refactoring or ah higher min SDK version
|
Good catch we should revisit this form time to time. For some of the deprecation there is no fix without raising min SDK version. There i propose to keep them until they are deprecated for good |
RkShaRkz
added a commit
to Cloud-City-RS/OMNTelcoMetrics
that referenced
this issue
Nov 4, 2024
Update from upstream since we were 93 commits behind Alright, we were 93 commits behind, now we should be up to speed... or probably +1 ahead due to the merge commit. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new `SharedPreferencesGrouper` class for improved management of shared preferences. - Added multiple new fragments including `DetailFragment`, `QuickFragment`, and `SharedPreferencesIOFragment`. - Implemented a `MultiSelectDialogFragment` for user-friendly multi-selection of preferences. - Enhanced UI with new layouts for displaying cell information (CDMA, GSM, LTE, NR). - Added new utility methods in `Iperf3Utils` for converting protocol and mode identifiers to strings. - Introduced a `PingFragment` for managing ping operations with a modern UI. - Added new layouts for quick views of various network types. - New `CloudCityConstants` class for centralized string constants related to Cloud City. - New `CloudCityParamsRepository` for managing application parameters related to the Cloud City service. - Added `sentry.properties` for Sentry integration to track errors and performance metrics. - **Bug Fixes** - Improved error handling across various components, including logging exceptions instead of printing stack traces. - **Documentation** - Updated comments and documentation across various classes for better clarity and maintainability. - **Style** - Enhanced UI elements with Material Design components and improved layout structures. - **Chores** - Cleaned up unused imports and removed deprecated code sections for better code hygiene. <!-- end of auto-generated comment: release notes by coderabbit.ai --> * added available location provider to home screen * removed inacurate log message * add basic config file export/import * update to use SPG instead of default SharedPreferences * wifi logging implemented. Needed some refactoring on permissions requests. Also fixes some issues on cp handling * add config GUI * update template config * add dynamic clearance of ScrollView if Clear button is pressed * rename * refactor MainActivity to prevent to early access of the data provider * android studio code optimization, lets hope for the best ;-) * Fix some of the deprecation warnings mentioned in omnt#28 the rest needs more refactoring or ah higher min SDK version * fix duplicate switch entry because of typo * move to separate Dir * fix bug * rework cell information code to be more robust for situation where no UICC is present or network is not available. Moved code from homefragment to main activity which only needs to be called once linter care * fix log icon reference not valid as to early access * update doc and fix Select Diag for Config import * pretty print config * update * update * remove DefaultSharedPreference * fix bug & add support for indefinitely running iperf3 * Added wifi standard to log / homescreen * check background permission on each start * update ping * refactor make it more readable * remove Intent * update Fragment if Cancel via Notification is clicked * fix "show neighbour cell setting did not take effect for home screen" * removed usage printStackTrace as it is considered bad practice in favor of using the logging framework * removed usage printStackTrace as it is considered bad practice in favor of using the logging framework * refactor some warnings in logging service * refactor some warnings in logging service * Print units to wifi information * Print units to wifi information * first part of fixing subscription selection * fix defaultsharedpreferences bug * Make sure to repopulate the data provider after an TM change * fix import config * fix wifi bug * split Homefragment into Quick View and Detail * add CellInformation to QuickView * add LTE/NR * refactor * update quick view * update quick view * update quick view * update quick view * add CDMA * add detail view * add detail view for every celltype * update signal strength * remove pretty print json * update * update * update * move Display code back to Fragment * add GSM quickview * add NR * Add QuickView to Hoimescreen vol. 2 (#33) * add CDMA * rename * add LTE * fix format issue * bump gradle to 8.6.0 * use MaterialTextView * add function comments * clean up --------- Co-authored-by: hajoha <[email protected]> * fix wrong value in RSSI for wifi * fix LTE/GSM/CDMA influx export * reworked duplicate logging strings * Clean up logging. Bumb some dependencies. Change app version to 0.4. * Clean up logging. Bumb some dependencies. Change app version to 0.4. Some further cleanup of logging refactoring. uncomment some code we will use in the future to make linter happy * Clean up logging. Bumb some dependencies. Change app version to 0.4. Some further cleanup of logging refactoring. Uncomment some code we will use in the future to make linter happy. Reworked subscription settings code to better handle no UICC present * Clean up logging. Bumb some dependencies. Change app version to 0.4. Some further cleanup of logging refactoring. Uncomment some code we will use in the future to make linter happy. Reworked subscription settings code to better handle no UICC present Update Changelog Bump gradle version * Clean up logging. Bumb some dependencies. Change app version to 0.4. Some further cleanup of logging refactoring. Uncomment some code we will use in the future to make linter happy. Reworked subscription settings code to better handle no UICC present Update Changelog Bump gradle version * clean up failed merge from 91cad78 * code cleanup and typo fix * update changelog * fixed wrong button state of ping fragment button after app start some cleanup in ping fragment * Add supported android versions to readme * typo in readme * remove deprecated checks and vars vom loggingservice * removed unneccessary call on update all information for quick view * cleanup in preparation for 0.4 release * bump influx client version to 7.2.0 * added Wifi Security Type to wifi information * Add alternative solution to enable carrier permissions * Add docs about IMS activation * Extract CloudCity changes to MainActivity EDIT: streamline even further, we'll rename these later on * Extract CloudCity changes to LoggingService * Address own CR comments - handle NPE * Fix prefilling of server params in logging settings part of the settings screen So, since they changed how they work with things and have kinda-but-not-really moved away from SharedPreferences by using their new SharedPreferencesGrouper which is just a dispatcher to many different shared preferences, the prefilling was broken by them started using the "logging_sp" SharedPreferences for the logging settings, while the cloud city-related preferenes were being saved in the default one. But apart from that, a new "source of truth" was made, the CloudCityParamsRepository which will hopefully hold all data together (and save them in it's own 'normal' sharedpref :( ) until it diverges from the values saved in their logging_sp shared pref. A new application class was made as well, which initializes the repository, and cloud city-related (string) parameters were extracted to the new CloudCityConstants class. the rest of the files were affected by minor refactoring or importing the new CloudCityConstants tl;dr - the prefilling works fine now again. * Integrate Sentry crashreporting for project mobile-app by using it's DSN (in metadata) * Move LoggingService cloudcity updates from main thread While extracting everything to have less changes in OMNT classes and more code in our "composite" classes, i accidentally used Looper.myLooper() instead of the old handler that was being used... so logging service would update every second on the UI thread. Whoops. My bad. * Previous fix wasn't so great, abandon the CloudCityHandler Makes no sense for the LoggingService to just have a handler which it'll pass over to our methods. Since our methods instantiate a new internal handler for the update thread, might as well also instantiate a new HandlerThread which will force the updates to a background thread (away from the main thread). So this fix is more resiliant to problems than the previous one (which also didn't work since the handler was never instantiated) * Update sentry project to new project * Add sentry properties so AndroidCI workflow can work again * More sentry updates * Separate the sentry.properties into two... So, according to the very bad and ambiguous documentation, there should apparently be two sentry.properties file: 1. where I originally put it, that just sets the DSN 2. one in the project root that defines the project, org and authToken So lets try this and see where that gets us. * Update auth token with the new one I made * Remove auth token from sentry.properties and just keep it as a repo secret * Revert "Remove auth token from sentry.properties and just keep it as a repo secret" This reverts commit e42638f. * Turn off sentry debug logs * Add coderabbit's CR suggestion to cache after loading from shared pref * Rework the last fix * Apply similar isBlank() fix to other places that were using regular isBlank() After all, the String#isBlank() is introduced in Java11 aka API34 so for devices running lower APIs we shouldn't use it; so we have to roll out our own version using String.trim().isEmpty() instead The Util method checks the API level and acts accordingly. --------- Co-authored-by: Peter Hasse <[email protected]> Co-authored-by: Johann <[email protected]> Co-authored-by: derpeter <[email protected]> Co-authored-by: hajoha <[email protected]> Co-authored-by: PeterHasse <[email protected]> Co-authored-by: Johann <[email protected]> Co-authored-by: errdemk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Context
Description
Fix warnings while compiling
How to Reproduce
add this to
app/build.gradleundercompileOptionsAdditional Context
The text was updated successfully, but these errors were encountered: