Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test output shapes with PyTest #28

Open
omar-abdelgawad opened this issue Jan 19, 2024 · 0 comments
Open

Test output shapes with PyTest #28

omar-abdelgawad opened this issue Jan 19, 2024 · 0 comments
Labels
good first issue Good for newcomers TODO Items that need completing

Comments

@omar-abdelgawad
Copy link
Owner

omar-abdelgawad commented Jan 19, 2024

Is your feature request related to a problem? Please describe.
Currently, some modules (.py files) which are not supposed to be run have a main function as a kind of sanity check for the person writing the nn.Module or whatever. Most commonly we check for the input and output Tensor shapes to make sure the dims are correct. For example we might check that the output of a Generator should have the same size as its input with the same number of channels.

Describe the solution you'd like
All of the above sanity checks should be written separately with pytest.

Additional context
Please write tests that make sure the shapes of output torch.Tensors are correct after going through the generator or discriminator.

@omar-abdelgawad omar-abdelgawad added enhancement New feature or request good first issue Good for newcomers labels Jan 19, 2024
@omar-abdelgawad omar-abdelgawad added TODO Items that need completing and removed enhancement New feature or request labels Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers TODO Items that need completing
Projects
None yet
Development

No branches or pull requests

1 participant