Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create service for Search Template API #977

Open
olivere opened this issue Nov 28, 2018 · 8 comments
Open

Create service for Search Template API #977

olivere opened this issue Nov 28, 2018 · 8 comments
Labels
Milestone

Comments

@olivere
Copy link
Owner

olivere commented Nov 28, 2018

See the REST API spec,
the documentation and
e.g. the official .NET client.

@olivere
Copy link
Owner Author

olivere commented Nov 28, 2018

Here's the code to generate a SearchTemplateRequest.

@prasad-marne
Copy link

i was looking for some example of how to implement searchTemplate POST using elastic library.
Links in this issue are broken. can u link some document where i can search using template.

@olivere
Copy link
Owner Author

olivere commented Mar 6, 2019

The latest API specification for 6.x can be found here now.

I guess the latest implemenation for 6.x is this.

@prasad-marne
Copy link

prasad-marne commented Mar 7, 2019

i would like to implement this service. I am not sure the best practice so can u guide me how should i go about implementing this service?

@ghost
Copy link

ghost commented Jul 8, 2020

Hi,

We use olivere/elastic and are looking at using _search/template. Therefore, we are interested in this feature. We might also be interested in contributing to this with a PR. Where should we look to find information about how to generate the service?

I found in a comment you made in another issue that you used https://github.com/olivere/elastic/tree/generate-api/generator to generate some code from the api spec.

Thank you.

@foxen
Copy link

foxen commented Jul 17, 2020

"API Status" marks Search Template as available, this is quite misleading

@olivere
Copy link
Owner Author

olivere commented Jul 17, 2020

@foxen It's partly implemented. E.g. you should be able to store, get, and delete a template. What is missing is search and render.

@olivere
Copy link
Owner Author

olivere commented Jul 17, 2020

Hi,

We use olivere/elastic and are looking at using _search/template. Therefore, we are interested in this feature. We might also be interested in contributing to this with a PR. Where should we look to find information about how to generate the service?

I found in a comment you made in another issue that you used https://github.com/olivere/elastic/tree/generate-api/generator to generate some code from the api spec.

Thank you.

@jackdbernier Yes, the code generator was a good starting point. Nowadays, as only few services get added between versions, I will mostly simply take an existing service as a blueprint.

For the implementation part, I always use the Java source as the ultimate truth. The ES documentation is very good and useful, but it's written for humans and is often ambiguous and lacks details you can only find in the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants