Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get adds github.com/olivere/elastic/v7 as an indirect dependency in go.mod #1334

Open
mukulGoelTokopedia opened this issue May 26, 2020 · 3 comments
Labels
Milestone

Comments

@mukulGoelTokopedia
Copy link

mukulGoelTokopedia commented May 26, 2020

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.

Which version of Elastic are you using?

elastic.v7 (for Elasticsearch 7.x)

Please describe the expected behavior

github.com/olivere/elastic/v7 should have been added as a direct dependency
import "github.com/olivere/elastic/v7" should be recognised as a valid path

Please describe the actual behavior

github.com/olivere/elastic/v7 added as an indirect dependency
import "github.com/olivere/elastic/v7" not recognised as a valid path

Any steps to reproduce the behavior?

  1. Go version is 1.14.3
  2. go get github.com/olivere/elastic/[email protected]
  3. go mod vendor
  4. import "github.com/olivere/elastic/v7" in your package
@mukulGoelTokopedia
Copy link
Author

mukulGoelTokopedia commented May 26, 2020

But when I first import "github.com/olivere/elastic/v7" in my package (without running go get) and then run go mod vendor, it's added as a direct dependency and import path is also recognised in my package

@olivere
Copy link
Owner

olivere commented May 27, 2020

Thanks for reporting. Yep, there's something wrong. I probably know why this happens, and will fix in the next release.

@olivere olivere added this to the 7.0.16 milestone May 27, 2020
@olivere olivere added the bug label May 27, 2020
@olivere
Copy link
Owner

olivere commented Jun 2, 2020

Hmm... for the moment, I'm not sure where this is coming from. Need to investigate a bit more.

@olivere olivere modified the milestones: 7.0.16, 7.0.17, 7.0.18 Jun 2, 2020
@olivere olivere modified the milestones: 7.0.18, 7.0.19 Jul 13, 2020
@olivere olivere modified the milestones: 7.0.19, 7.0.20 Jul 25, 2020
@olivere olivere modified the milestones: 7.0.20, 7.0.21 Aug 30, 2020
@olivere olivere modified the milestones: 7.0.21, 7.x Oct 16, 2020
@olivere olivere modified the milestones: 7.x, 8.x Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants